From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v5 0/7] Block Throttle Group Support
Date: Mon, 30 Mar 2015 17:16:12 +0300 [thread overview]
Message-ID: <cover.1427723718.git.berto@igalia.com> (raw)
One more try, the changes in this series are smaller compared to the
previous one, the most important fixes are related to the tests.
V5:
- Fixed and expanded the tests. There's a new one that checks that
configuration changes affect the whole throttling group.
- Refactored the code a bit: new function schedule_next_request()
- any_timer_armed is now reset in throttle_group_config(), it was
causing qemu-iotest 093 to fail.
- Documentation improvements
V4: https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg05558.html
- All functions from the ThrottleGroup API now receive a BlockDriverState.
- The creation/destruction of ThrottleTimers is now handled internally.
- bdrv_io_limits_enable() no longer accepts NULL as a valid group name.
- No member of a group can access someone else's throttled_reqs queues
anymore.
- No member of a group can access someone else's timers unless they
have queued requests.
- After a timer is fired make sure that there was actually a request
in the queue, and schedule a new one otherwise.
- Protect bdrv_swap() by locking the throttling group.
- throttle_group_co_io_limits_intercept() is now marked as a coroutine
function.
- Documentation updates.
Regards,
Berto
Alberto Garcia (6):
throttle: Add throttle group infrastructure
throttle: Add throttle group infrastructure tests
throttle: Add throttle group support
throttle: acquire the ThrottleGroup lock in bdrv_swap()
throttle: add the name of the ThrottleGroup to BlockDeviceInfo
throttle: Update throttle infrastructure copyright
Benoît Canet (1):
throttle: Extract timers from ThrottleState into a separate structure
block.c | 101 ++++-----
block/Makefile.objs | 1 +
block/qapi.c | 8 +-
block/throttle-groups.c | 489 ++++++++++++++++++++++++++++++++++++++++
blockdev.c | 22 +-
hmp.c | 10 +-
include/block/block.h | 3 +-
include/block/block_int.h | 7 +-
include/block/throttle-groups.h | 46 ++++
include/qemu/throttle.h | 46 ++--
qapi/block-core.json | 8 +-
qemu-options.hx | 1 +
qmp-commands.hx | 3 +-
tests/test-throttle.c | 152 +++++++++----
util/throttle.c | 81 ++++---
15 files changed, 822 insertions(+), 156 deletions(-)
create mode 100644 block/throttle-groups.c
create mode 100644 include/block/throttle-groups.h
--
2.1.4
next reply other threads:[~2015-03-30 14:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 14:16 Alberto Garcia [this message]
2015-03-30 14:16 ` [Qemu-devel] [PATCH 1/7] throttle: Extract timers from ThrottleState into a separate structure Alberto Garcia
2015-03-30 14:16 ` [Qemu-devel] [PATCH 2/7] throttle: Add throttle group infrastructure Alberto Garcia
2015-03-30 14:16 ` [Qemu-devel] [PATCH 3/7] throttle: Add throttle group infrastructure tests Alberto Garcia
2015-03-30 14:16 ` [Qemu-devel] [PATCH 4/7] throttle: Add throttle group support Alberto Garcia
2015-03-30 14:16 ` [Qemu-devel] [PATCH 5/7] throttle: acquire the ThrottleGroup lock in bdrv_swap() Alberto Garcia
2015-03-30 14:16 ` [Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo Alberto Garcia
2015-03-30 14:16 ` [Qemu-devel] [PATCH 7/7] throttle: Update throttle infrastructure copyright Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1427723718.git.berto@igalia.com \
--to=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.