All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: rostedt@goodmis.org, pebolle@tiscali.nl
Cc: linux-kernel@vger.kernel.org, Tom Zanussi <tom.zanussi@linux.intel.com>
Subject: [PATCH 0/4] kallsyms header cleanup
Date: Fri, 10 Apr 2015 11:04:59 -0500	[thread overview]
Message-ID: <cover.1428678555.git.tom.zanussi@linux.intel.com> (raw)

During review of an unrelated patchset, the question was asked why
module.h was included in code that wouldn't be a module and didn't do
anything with modules [1].

The reason is that it uses kallsyms defines, but kallsyms.h doesn't
include module.h, though it should because it uses MODULE_NAME_LEN.
The code in question also didn't include kallsyms.h but relied on
ftrace.h to pull it in.  But ftrace.h no longer contains anything that
needs kallsyms.h, and continues to include it only because other code
expects it to.

This patchset is the start of cleaning all that up.  It also adds
explicit kallsyms.h includes and removes module.h includes for obvious
cases in kernel/trace and lib/, where I happened to be working.

There are a bunch of other files that probably include module.h only
for kallsyms, but I haven't gone through them yet.  I can either
resubmit this patchset after looking at all those, or can submit a
follow-on patchset to this one assuming this is best way to do it...

[1] https://lkml.org/lkml/2015/4/4/70

The following changes since commit 3cfb2f7976a2f9cfe48eda4e6d7e4ce74fee09e3:

  Merge tag 'pci-v4.0-fixes-3' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci (2015-04-09 10:17:44 -0700)

are available in the git repository at:


  git://git.yoctoproject.org/linux-yocto-contrib.git tzanussi/kallsyms-header-cleanup
  http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-contrib/log/?h=tzanussi/kallsyms-header-cleanup

Tom Zanussi (4):
  tracing: Remove kallsyms.h include from linux/ftrace.h
  kallsyms: Add module.h include
  tracing: Remove redundant module.h includes
  lib: Remove redundant module.h includes

 include/linux/ftrace.h            | 1 -
 include/linux/kallsyms.h          | 1 +
 kernel/trace/trace.c              | 1 -
 kernel/trace/trace_branch.c       | 1 -
 kernel/trace/trace_export.c       | 1 -
 kernel/trace/trace_irqsoff.c      | 1 -
 kernel/trace/trace_kprobe.c       | 1 +
 kernel/trace/trace_output.c       | 2 +-
 kernel/trace/trace_sched_switch.c | 1 -
 kernel/trace/trace_sched_wakeup.c | 1 -
 kernel/trace/trace_stack.c        | 1 -
 kernel/trace/trace_syscalls.c     | 2 +-
 lib/vsprintf.c                    | 2 +-
 13 files changed, 5 insertions(+), 11 deletions(-)

-- 
1.9.3


             reply	other threads:[~2015-04-10 16:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10 16:04 Tom Zanussi [this message]
2015-04-10 16:05 ` [PATCH 1/4] tracing: Remove kallsyms.h include from linux/ftrace.h Tom Zanussi
2015-04-10 16:05 ` [PATCH 2/4] kallsyms: Add module.h include Tom Zanussi
2015-04-10 16:05 ` [PATCH 3/4] tracing: Remove redundant module.h includes Tom Zanussi
2015-04-10 16:27   ` Steven Rostedt
2015-04-10 18:25     ` Tom Zanussi
2015-04-10 18:54       ` Steven Rostedt
2015-04-10 16:05 ` [PATCH 4/4] lib: " Tom Zanussi
2015-04-10 16:28   ` Steven Rostedt
2015-04-10 18:27     ` Tom Zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1428678555.git.tom.zanussi@linux.intel.com \
    --to=tom.zanussi@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.