From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7bDp-0006H4-3r for qemu-devel@nongnu.org; Tue, 23 Jun 2015 23:19:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7bDk-00069j-E2 for qemu-devel@nongnu.org; Tue, 23 Jun 2015 23:19:33 -0400 Received: from mail-pa0-x22b.google.com ([2607:f8b0:400e:c03::22b]:33750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7bDk-00068G-7I for qemu-devel@nongnu.org; Tue, 23 Jun 2015 23:19:28 -0400 Received: by padev16 with SMTP id ev16so19775575pad.0 for ; Tue, 23 Jun 2015 20:19:27 -0700 (PDT) From: Peter Crosthwaite Date: Tue, 23 Jun 2015 20:19:19 -0700 Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH qom v3 0/4] qom-cpu: Wrap set_pc hook and use in bootloaders List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Peter Crosthwaite , afaerber@suse.de, edgar.iglesias@gmail.com Wrap the CPUClass::set_pc fn hook in a caller helper to reduce verbosity of calls. Simplify the call from the gdbstub. Then use the call to abstract away the PC env fields from the ARM and Microblaze bootloaders. This moves towards the goal of minimising system level code of the CPU env (and one step closer to common-obj'ing the bootloaders). There's a long way to go (at least for ARM, not so far for MB), but this is a small win in that direction. This helps with multi-arch where the current thinking is to compile out the maximum content possible from cpu.h. This removes program counter definitions from the multi-arch cpu.h compile-in list. changed since v2: drop error argument misc commit messages tweaks changed since v1: Remove thumb changes Peter Crosthwaite (4): cpu: Add wrapper to the set-pc() hook gdbstub: Use cpu_set_pc() helper arm: boot: Use cpu_set_pc() microblaze: boot: Use cpu_set_pc() dtc | 2 +- gdbstub.c | 5 +---- hw/arm/boot.c | 19 +++++++------------ hw/microblaze/boot.c | 2 +- include/qom/cpu.h | 17 +++++++++++++++++ 5 files changed, 27 insertions(+), 18 deletions(-) -- 1.9.1