All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 0/1] Allow passing BlockdevOptions to blockdev-snapshot-sync
Date: Mon, 31 Aug 2015 13:00:23 +0300	[thread overview]
Message-ID: <cover.1441014844.git.berto@igalia.com> (raw)

Here's my first attempt to solve the problem explained here:

   https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02847.html

In short: there's no way to pass options to snapshots created using
blockdev-snapshot-sync.

This patch simply allows passing a BlockdevOptions structure to that
command. I'm not 100% happy with the API because there's some overlap
with a couple of parameters, but it's the simplest I could think of.

This need to be applied on top of this series from Max Reitz:

   https://lists.gnu.org/archive/html/qemu-block/2015-08/msg00189.html

Regards,

Berto

Alberto Garcia (1):
  block: Allow passing BlockdevOptions to blockdev-snapshot-sync

 blockdev.c           | 59 ++++++++++++++++++++++++++++++++++++++++++++++------
 hmp.c                |  2 +-
 qapi/block-core.json |  9 +++++++-
 qmp-commands.hx      |  3 ++-
 4 files changed, 64 insertions(+), 9 deletions(-)

-- 
2.5.0

             reply	other threads:[~2015-08-31 10:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31 10:00 Alberto Garcia [this message]
2015-08-31 10:00 ` [Qemu-devel] [PATCH 1/1] block: Allow passing BlockdevOptions to blockdev-snapshot-sync Alberto Garcia
2015-08-31 19:53   ` Max Reitz
2015-08-31 20:05     ` Eric Blake
2015-08-31 20:12       ` Max Reitz
2015-09-01 11:33         ` Kevin Wolf
2015-09-01 11:31       ` Kevin Wolf
2015-09-01 14:22         ` Alberto Garcia
2015-09-01 14:40           ` Kevin Wolf
2015-09-02  7:04             ` Markus Armbruster
2015-09-02 14:23             ` Alberto Garcia
2015-09-02 15:43               ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1441014844.git.berto@igalia.com \
    --to=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.