From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756675AbbJAPR2 (ORCPT ); Thu, 1 Oct 2015 11:17:28 -0400 Received: from ou.quest-ce.net ([195.154.187.82]:39375 "EHLO ou.quest-ce.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752716AbbJAPR0 (ORCPT ); Thu, 1 Oct 2015 11:17:26 -0400 From: Yann Droneaud To: Peter Zijlstra , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Jiri Olsa Cc: Yann Droneaud , Adrian Hunter , David Ahern , David Ahern , Frederic Weisbecker , Jiri Olsa , Namhyung Kim , Peter Zijlstra , Stephane Eranian , William Cohen , linux-kernel@vger.kernel.org Date: Thu, 1 Oct 2015 17:16:24 +0200 Message-Id: X-Mailer: git-send-email 2.4.3 X-SA-Exim-Connect-IP: 2001:450:1e:232:8e70:5aff:fe2f:2d74 X-SA-Exim-Mail-From: ydroneaud@opteya.com Subject: [PATCH v2 0/2] perf tool: improve error handling in perf_flag_probe() X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ou.quest-ce.net) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Following the EBUSY errors reported by Jiri Olsa [1], I've tryed to improve a bit the way perf_flag_probe() handle errors. In case EBUSY is returned by perf_event_open(), testing the function again without PERF_FLAG_FD_CLOEXEC is meaningless: EBUSY is not related to close-on-exec flag, so there's nothing to confirm. For other errors, not yet explicitly handled by perf_flag_probe(), it's pointless to report a second error message for the same error code: the second check should not print an error if the error is the same as the one returned for the first check. Changes from v1 [2]: - resend Changes from v0 [3]: - rebased on top of commit 48536c9195ae ("perf tools: Fix probing for PERF_FLAG_FD_CLOEXEC flag"); - update a bit commit message; - the previous patchset was acked by Jiri[4], but I haven't reported Acked-by: in this updated patchset. [1] http://lkml.kernel.org/r/1406908014-8312-1-git-send-email-jolsa@kernel.org [2] http://lkml.kernel.org/r/cover.1425901229.git.ydroneaud@opteya.com [3] http://lkml.kernel.org/r/cover.1410595700.git.ydroneaud@opteya.com [4] http://lkml.kernel.org/r/20140920121438.GB15481@krava.brq.redhat.com Yann Droneaud (2): perf tools: shortcut PERF_FLAG_FD_CLOEXEC probing in case of EBUSY error perf tools: report PERF_FLAG_FD_CLOEXEC probing error once tools/perf/util/cloexec.c | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) -- 2.4.3