From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6208143559134019584 Date: Thu, 22 Oct 2015 03:32:28 -0700 (PDT) From: Navya Sri Nizamkari To: outreachy-kernel Cc: daniel.baluta@gmail.com, navyasri.tech@gmail.com Message-Id: In-Reply-To: References: Subject: Re: [Outreachy kernel] [PATCH 1/5] Staging: xgifb: Add space between ; and variable name MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_792_1442585192.1445509948122" X-Google-Token: ELz2orEFuCHIPbMZw280 X-Google-IP: 27.6.34.222 ------=_Part_792_1442585192.1445509948122 Content-Type: multipart/alternative; boundary="----=_Part_793_1625798654.1445509948123" ------=_Part_793_1625798654.1445509948123 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Thursday, October 22, 2015 at 2:12:48 PM UTC+5:30, Julia Lawall wrote: > > On Thu, 22 Oct 2015, Daniel Baluta wrote: > > > On Wed, Oct 21, 2015 at 7:48 PM, Navya Sri Nizamkari > > > wrote: > > > This patch fixes the checkpatch.pl error: > > > > > > ERROR: space required after that ';' > > > > > > Signed-off-by: Navya Sri Nizamkari > > > > > --- > > > drivers/staging/xgifb/vb_init.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/xgifb/vb_init.c > b/drivers/staging/xgifb/vb_init.c > > > index ea358a0..6204a98 100644 > > > --- a/drivers/staging/xgifb/vb_init.c > > > +++ b/drivers/staging/xgifb/vb_init.c > > > @@ -10,7 +10,7 @@ static const unsigned short > XGINew_DDRDRAM_TYPE340[4][2] = { > > > { 16, 0x45}, > > > { 8, 0x35}, > > > { 4, 0x31}, > > > - { 2, 0x21} };e > > > + { 2, 0x21} }; e > > > > Hmm, something went wrong here :) > > > > Please edit the file and remove 'e' after ';'. Otherwise, your code > > wouldn't even compile. > > Also, this seems to be a patch on top of your previous patch, whereas your > corrected patches should be on top of the current state of Greg's tree. > > julia > > I introduced the 'e' as a typo. I'll revert and send the patchset without this patch. Thanks. > > > > thanks, > > Daniel. > > > > -- > > You received this message because you are subscribed to the Google > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to outreachy-kern...@googlegroups.com . > > To post to this group, send email to outreach...@googlegroups.com > . > > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/CAEnQRZBqVWVHtc_pRUemU-6qZMmbD90TzuGsWe-5Xuh63mXG2A%40mail.gmail.com. > > > For more options, visit https://groups.google.com/d/optout. > > > ------=_Part_793_1625798654.1445509948123 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

On Thursday, October 22, 2015 at 2:12:48 PM UTC+5:30, Julia Lawall = wrote:
On Thu, 22 Oct 2015, Dan= iel Baluta wrote:

> On Wed, Oct 21, 2015 at 7:48 PM, Navya Sri Nizamkari
> <navyas...@gmail.com> wrote:
> > This patch fixes the checkpatch.pl error:
> >
> > ERROR: space required after that ';'
> >
> > Signed-off-by: Navya Sri Nizamkari <navyas...@gmail.com>
> > ---
> > =C2=A0drivers/staging/xgifb/vb_init.c | 2 +-
> > =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/s= taging/xgifb/vb_init.c
> > index ea358a0..6204a98 100644
> > --- a/drivers/staging/xgifb/vb_init.c
> > +++ b/drivers/staging/xgifb/vb_init.c
> > @@ -10,7 +10,7 @@ static const unsigned short XGINew_DDRDRAM_= TYPE340[4][2] =3D {
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 { 16, 0x45},
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 { =C2=A08, 0x35},
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 { =C2=A04, 0x31},
> > - =C2=A0 =C2=A0 =C2=A0 { =C2=A02, 0x21} };e
> > + =C2=A0 =C2=A0 =C2=A0 { =C2=A02, 0x21} }; e
>
> Hmm, something went wrong here :)
>
> Please edit the file and remove 'e' after ';'. Oth= erwise, your code
> wouldn't even compile.

Also, this seems to be a patch on top of your previous patch, whereas y= our
corrected patches should be on top of the current state of Greg's t= ree.

julia


I introduced the 'e' as a typo. I'll = revert and send the patchset without this patch. Thanks.
>
> thanks,
> Daniel.
>
> --
> You received this message because you are subscribed to the Google= Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, = send an email to outreachy-kern...@googlegroups= .com.
> To post to this group, send email to outrea= ch...@googlegroups.com.
> To view this discussion on the web visit https://= groups.google.com/d/msgid/outreachy-kernel/CAEnQRZBqVWVHtc_pRUemU= -6qZMmbD90TzuGsWe-5Xuh63mXG2A%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/op= tout.
>
------=_Part_793_1625798654.1445509948123-- ------=_Part_792_1442585192.1445509948122-- From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6208143559134019584 Date: Thu, 22 Oct 2015 03:30:57 -0700 (PDT) From: Navya Sri Nizamkari To: outreachy-kernel Cc: navyasri.tech@gmail.com Message-Id: In-Reply-To: References: Subject: Re: [Outreachy kernel] [PATCH 1/5] Staging: xgifb: Add space between ; and variable name MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_787_1161446475.1445509857665" X-Google-Token: EOH1orEF-RDEoTQi8Yw0 X-Google-IP: 27.6.34.222 ------=_Part_787_1161446475.1445509857665 Content-Type: multipart/alternative; boundary="----=_Part_788_1149586504.1445509857665" ------=_Part_788_1149586504.1445509857665 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Thursday, October 22, 2015 at 2:08:02 PM UTC+5:30, Daniel Baluta wrote: > > On Wed, Oct 21, 2015 at 7:48 PM, Navya Sri Nizamkari > > wrote: > > This patch fixes the checkpatch.pl error: > > > > ERROR: space required after that ';' > > > > Signed-off-by: Navya Sri Nizamkari > > > --- > > drivers/staging/xgifb/vb_init.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/xgifb/vb_init.c > b/drivers/staging/xgifb/vb_init.c > > index ea358a0..6204a98 100644 > > --- a/drivers/staging/xgifb/vb_init.c > > +++ b/drivers/staging/xgifb/vb_init.c > > @@ -10,7 +10,7 @@ static const unsigned short > XGINew_DDRDRAM_TYPE340[4][2] = { > > { 16, 0x45}, > > { 8, 0x35}, > > { 4, 0x31}, > > - { 2, 0x21} };e > > + { 2, 0x21} }; e > > Hmm, something went wrong here :) > > Please edit the file and remove 'e' after ';'. Otherwise, your code > wouldn't even compile. > > thanks, > Daniel. > This 'e' seems the typo introduced by me. Sorry. Thanks for the correction. ------=_Part_788_1149586504.1445509857665 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

On Thursday, October 22, 2015 at 2:08:02 PM UTC+5:30, Daniel Baluta= wrote:
On Wed, Oct 21, 2015 at= 7:48 PM, Navya Sri Nizamkari
<navyas...@gmail.com> wrote:
> This patch fixes the checkpatch.pl error:
>
> ERROR: space required after that ';'
>
> Signed-off-by: Navya Sri Nizamkari <navy= as...@gmail.com>
> ---
> =C2=A0drivers/staging/xgifb/vb_init.c | 2 +-
> =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/stagin= g/xgifb/vb_init.c
> index ea358a0..6204a98 100644
> --- a/drivers/staging/xgifb/vb_init.c
> +++ b/drivers/staging/xgifb/vb_init.c
> @@ -10,7 +10,7 @@ static const unsigned short XGINew_DDRDRAM_TYPE3= 40[4][2] =3D {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 { 16, 0x45},
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 { =C2=A08, 0x35},
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 { =C2=A04, 0x31},
> - =C2=A0 =C2=A0 =C2=A0 { =C2=A02, 0x21} };e
> + =C2=A0 =C2=A0 =C2=A0 { =C2=A02, 0x21} }; e

Hmm, something went wrong here :)

Please edit the file and remove 'e' after ';'. Otherwis= e, your code
wouldn't even compile.

thanks,
Daniel.

This 'e' seems the typo introduced by me.= Sorry. Thanks for the correction.
------=_Part_788_1149586504.1445509857665-- ------=_Part_787_1161446475.1445509857665-- From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6208143559134019584 X-Received: by 10.112.144.105 with SMTP id sl9mr3329457lbb.3.1445503368149; Thu, 22 Oct 2015 01:42:48 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.180.126.5 with SMTP id mu5ls576026wib.17.gmail; Thu, 22 Oct 2015 01:42:47 -0700 (PDT) X-Received: by 10.180.10.202 with SMTP id k10mr8029364wib.2.1445503367675; Thu, 22 Oct 2015 01:42:47 -0700 (PDT) Return-Path: Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr. [192.134.164.104]) by gmr-mx.google.com with ESMTPS id cm6si81991wib.1.2015.10.22.01.42.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Oct 2015 01:42:47 -0700 (PDT) Received-SPF: neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) client-ip=192.134.164.104; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr X-IronPort-AV: E=Sophos;i="5.20,181,1444687200"; d="scan'208";a="151402122" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-SHA; 22 Oct 2015 10:42:46 +0200 Date: Thu, 22 Oct 2015 10:42:36 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Daniel Baluta cc: Navya Sri Nizamkari , outreachy-kernel Subject: Re: [Outreachy kernel] [PATCH 1/5] Staging: xgifb: Add space between ; and variable name In-Reply-To: Message-ID: References: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII On Thu, 22 Oct 2015, Daniel Baluta wrote: > On Wed, Oct 21, 2015 at 7:48 PM, Navya Sri Nizamkari > wrote: > > This patch fixes the checkpatch.pl error: > > > > ERROR: space required after that ';' > > > > Signed-off-by: Navya Sri Nizamkari > > --- > > drivers/staging/xgifb/vb_init.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c > > index ea358a0..6204a98 100644 > > --- a/drivers/staging/xgifb/vb_init.c > > +++ b/drivers/staging/xgifb/vb_init.c > > @@ -10,7 +10,7 @@ static const unsigned short XGINew_DDRDRAM_TYPE340[4][2] = { > > { 16, 0x45}, > > { 8, 0x35}, > > { 4, 0x31}, > > - { 2, 0x21} };e > > + { 2, 0x21} }; e > > Hmm, something went wrong here :) > > Please edit the file and remove 'e' after ';'. Otherwise, your code > wouldn't even compile. Also, this seems to be a patch on top of your previous patch, whereas your corrected patches should be on top of the current state of Greg's tree. julia > > thanks, > Daniel. > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAEnQRZBqVWVHtc_pRUemU-6qZMmbD90TzuGsWe-5Xuh63mXG2A%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. > From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6208143559134019584 X-Received: by 10.180.210.212 with SMTP id mw20mr8007395wic.3.1445503082673; Thu, 22 Oct 2015 01:38:02 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.25.41.4 with SMTP id p4ls280578lfp.58.gmail; Thu, 22 Oct 2015 01:37:59 -0700 (PDT) X-Received: by 10.112.173.170 with SMTP id bl10mr3344036lbc.7.1445503079868; Thu, 22 Oct 2015 01:37:59 -0700 (PDT) Return-Path: Received: from mail-wi0-x22b.google.com (mail-wi0-x22b.google.com. [2a00:1450:400c:c05::22b]) by gmr-mx.google.com with ESMTPS id em5si196414wib.2.2015.10.22.01.37.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Oct 2015 01:37:59 -0700 (PDT) Received-SPF: pass (google.com: domain of daniel.baluta@gmail.com designates 2a00:1450:400c:c05::22b as permitted sender) client-ip=2a00:1450:400c:c05::22b; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of daniel.baluta@gmail.com designates 2a00:1450:400c:c05::22b as permitted sender) smtp.mailfrom=daniel.baluta@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com Received: by mail-wi0-x22b.google.com with SMTP id p11so19007733wij.0 for ; Thu, 22 Oct 2015 01:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=gbK1Lja0pyyk9AVH2y7k6UCJu1Ikl4saZD5pmTk56AE=; b=MoVBU+ItSb1iDJGjU/NONToLDovXQ8ZN7AmdOZHWMl9eq9E1dLrTx32Y51562fqNrG AqfyD0jDvtg4npMllRvcvFz1KxmHxCJ9dIj0TTGJcoAruPhjk546woUxhqaOGtjjqWnG st60FAImYLL1uIRNx8y0PEVyQktZUi5Wq1rkbD7pSDlzNFjbZ5Xsm995QD8fK2IX3yw/ yg4LUCwoMti1sJAv+PjTJjl9dXP1WbSCxQusSIKvtEYtE9hL3RrVzaagcHkECw5oka9k 3WqP7otSaOPoTNR6vtb0TfQFthnJyFL46jwAI9a3l5RllAVzDDUfg+3jHapwJt/hEzm4 TcPw== MIME-Version: 1.0 X-Received: by 10.180.86.231 with SMTP id s7mr37603770wiz.15.1445503079707; Thu, 22 Oct 2015 01:37:59 -0700 (PDT) Received: by 10.194.165.102 with HTTP; Thu, 22 Oct 2015 01:37:59 -0700 (PDT) In-Reply-To: References: Date: Thu, 22 Oct 2015 11:37:59 +0300 Message-ID: Subject: Re: [Outreachy kernel] [PATCH 1/5] Staging: xgifb: Add space between ; and variable name From: Daniel Baluta To: Navya Sri Nizamkari Cc: outreachy-kernel Content-Type: text/plain; charset=UTF-8 On Wed, Oct 21, 2015 at 7:48 PM, Navya Sri Nizamkari wrote: > This patch fixes the checkpatch.pl error: > > ERROR: space required after that ';' > > Signed-off-by: Navya Sri Nizamkari > --- > drivers/staging/xgifb/vb_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c > index ea358a0..6204a98 100644 > --- a/drivers/staging/xgifb/vb_init.c > +++ b/drivers/staging/xgifb/vb_init.c > @@ -10,7 +10,7 @@ static const unsigned short XGINew_DDRDRAM_TYPE340[4][2] = { > { 16, 0x45}, > { 8, 0x35}, > { 4, 0x31}, > - { 2, 0x21} };e > + { 2, 0x21} }; e Hmm, something went wrong here :) Please edit the file and remove 'e' after ';'. Otherwise, your code wouldn't even compile. thanks, Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6208143559134019584 X-Received: by 10.182.70.4 with SMTP id i4mr8352093obu.15.1445446269619; Wed, 21 Oct 2015 09:51:09 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.107.12.14 with SMTP id w14ls574913ioi.38.gmail; Wed, 21 Oct 2015 09:51:09 -0700 (PDT) X-Received: by 10.67.23.163 with SMTP id ib3mr8426999pad.45.1445446269248; Wed, 21 Oct 2015 09:51:09 -0700 (PDT) Return-Path: Received: from mail-pa0-x22e.google.com (mail-pa0-x22e.google.com. [2607:f8b0:400e:c03::22e]) by gmr-mx.google.com with ESMTPS id ce6si1214126pad.0.2015.10.21.09.51.09 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2015 09:51:09 -0700 (PDT) Received-SPF: pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c03::22e as permitted sender) client-ip=2607:f8b0:400e:c03::22e; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c03::22e as permitted sender) smtp.mailfrom=navyasri.tech@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com Received: by mail-pa0-x22e.google.com with SMTP id rc13so59530802pab.0 for ; Wed, 21 Oct 2015 09:51:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=U2xbghtx01UK3a9DwvpREar8PEP3eOvsMlFRXSwxYX0=; b=o1qPLfPCAggIJEg/I+qACutmQbXDgi8zOBrGCWrv4ReMkiM8L6qr+/RX/YwP0a+cpf /uB8kKYxBiWpJctG5Jjm0JBKqOusnHuIZd7ENyKaYTW19ZrgzK4BB77Q6NWmjLTILTWF AzFnh3H7MIbuXm9gHOsBsHRRQZSGco1wWJluWJ/cYns2lsplAp0hFNXIpFV1pelgW0vk BVQxa9B/uUsipOwQjiXwJmKjQGKoBLfOu3jhEP0p+DzX5YRUodQg0Ll9Nz36qvsaKE4X ltJNLxngy62LsJkdOCVwGghIVfZmVVkQB7I+EmuG0ghlOpRlL/bK6/jq+vXCy4ZhX/q/ OruA== X-Received: by 10.68.197.168 with SMTP id iv8mr11505522pbc.81.1445446269144; Wed, 21 Oct 2015 09:51:09 -0700 (PDT) Return-Path: Received: from navya ([27.6.33.173]) by smtp.gmail.com with ESMTPSA id ss6sm10037993pbc.74.2015.10.21.09.51.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Oct 2015 09:51:08 -0700 (PDT) Date: Wed, 21 Oct 2015 22:21:11 +0530 From: Navya Sri Nizamkari To: outreachy-kernel@googlegroups.com Cc: outreachy-kernel@googlegroups.com Subject: [PATCH 5/5] Staging: xgifb: Remove space after cast Message-ID: <2a77ddfac958341380e824b5f5376b97978f6a78.1445445320.git.navyasri.tech@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) This patch fixes the checkpatch check: CHECK: No space is necessary after a cast Signed-off-by: Navya Sri Nizamkari --- drivers/staging/xgifb/vb_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index 0615f1c..cef24b3 100644 --- a/drivers/staging/xgifb/vb_init.c +++ b/drivers/staging/xgifb/vb_init.c @@ -815,7 +815,7 @@ static int XGINew_DDRSizing340(struct xgi_hw_device_info *HwDeviceExtension, memsize += (pVBInfo->ram_channel - 2) + 20; if ((HwDeviceExtension->ulVideoMemorySize - 1) < - (unsigned long) (1 << memsize)) + (unsigned long)(1 << memsize)) continue; if (XGINew_ReadWriteRest(memsize, start_addr, pVBInfo) == 1) @@ -836,7 +836,7 @@ static void XGINew_SetDRAMSize_340(struct xgifb_video_info *xgifb_info, data = xgifb_reg_get(pVBInfo->P3c4, 0x21); /* disable read cache */ - xgifb_reg_set(pVBInfo->P3c4, 0x21, (unsigned short) (data & 0xDF)); + xgifb_reg_set(pVBInfo->P3c4, 0x21, (unsigned short)(data & 0xDF)); XGI_DisplayOff(xgifb_info, HwDeviceExtension, pVBInfo); XGINew_DDRSizing340(HwDeviceExtension, pVBInfo); -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6208143559134019584 X-Received: by 10.68.138.233 with SMTP id qt9mr8487752pbb.11.1445446236012; Wed, 21 Oct 2015 09:50:36 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.182.103.161 with SMTP id fx1ls457399obb.44.gmail; Wed, 21 Oct 2015 09:50:35 -0700 (PDT) X-Received: by 10.182.246.98 with SMTP id xv2mr9106425obc.3.1445446235656; Wed, 21 Oct 2015 09:50:35 -0700 (PDT) Return-Path: Received: from mail-pa0-x235.google.com (mail-pa0-x235.google.com. [2607:f8b0:400e:c03::235]) by gmr-mx.google.com with ESMTPS id el2si1178144pbb.0.2015.10.21.09.50.35 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2015 09:50:35 -0700 (PDT) Received-SPF: pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c03::235 as permitted sender) client-ip=2607:f8b0:400e:c03::235; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c03::235 as permitted sender) smtp.mailfrom=navyasri.tech@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com Received: by mail-pa0-x235.google.com with SMTP id fv9so61901375pac.3 for ; Wed, 21 Oct 2015 09:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=+TmuZRL5XmDy3VfxzHeRz9EC2KxqJbqm+sgSLTfNfms=; b=GuTbwv9c+oRqmtbbxXC8CUvOS4kqi/dGROhMhiw1Uz7m1IXhl4icHGcoIMSPbQBWaO oRSQRNbksx+q4dXvPvlDJhETWSoS462J68I+7hQHGm4Rs9RpeTcJz0PCuLbfJdkDcCWY a5pEf58oKBYjLYsLCkMVxRBO/3kgXeyD8/ImchpGontrfSavDMBakujdMo1oOMvTBJ/a j7B/hU34xZ1/EnS9TiAZTBlUPt5TIY5J5f8lUaz6MkHYW1HkQ0YYi7dWF7MQK/5jxnUU MRM6dOwGB3FJ/TZAW6bZDV9nuWca8vOGnpyFRPPKgz6/4493uOlZO8f1EsexZA3JiOW3 P7nA== X-Received: by 10.67.16.15 with SMTP id fs15mr11772032pad.82.1445446235425; Wed, 21 Oct 2015 09:50:35 -0700 (PDT) Return-Path: Received: from navya ([27.6.33.173]) by smtp.gmail.com with ESMTPSA id bs3sm10027498pbd.89.2015.10.21.09.50.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Oct 2015 09:50:35 -0700 (PDT) Date: Wed, 21 Oct 2015 22:20:38 +0530 From: Navya Sri Nizamkari To: outreachy-kernel@googlegroups.com Cc: outreachy-kernel@googlegroups.com Subject: [PATCH 4/5] Staging: xgifb: Fix comparison to NULL warning Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Change comparison to NULL to a ! operation. Found using checkpatch. Signed-off-by: Navya Sri Nizamkari --- drivers/staging/xgifb/vb_init.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index 1aa8600..0615f1c 100644 --- a/drivers/staging/xgifb/vb_init.c +++ b/drivers/staging/xgifb/vb_init.c @@ -851,11 +851,11 @@ static u8 *xgifb_copy_rom(struct pci_dev *dev, size_t *rom_size) u8 *rom_copy; rom_address = pci_map_rom(dev, rom_size); - if (rom_address == NULL) + if (!rom_address) return NULL; rom_copy = vzalloc(XGIFB_ROM_SIZE); - if (rom_copy == NULL) + if (!rom_copy) goto done; *rom_size = min_t(size_t, *rom_size, XGIFB_ROM_SIZE); @@ -877,7 +877,7 @@ static bool xgifb_read_vbios(struct pci_dev *pdev) int entry; vbios = xgifb_copy_rom(pdev, &vbios_size); - if (vbios == NULL) { + if (!vbios) { dev_err(&pdev->dev, "Video BIOS not available\n"); return false; } @@ -1187,7 +1187,7 @@ unsigned char XGIInitNew(struct pci_dev *pdev) pVBInfo->FBAddr = HwDeviceExtension->pjVideoMemoryAddress; - if (pVBInfo->FBAddr == NULL) { + if (!pVBInfo->FBAddr) { dev_dbg(&pdev->dev, "pVBInfo->FBAddr == 0\n"); return 0; } -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6208143559134019584 X-Received: by 10.182.245.163 with SMTP id xp3mr6629588obc.19.1445446202569; Wed, 21 Oct 2015 09:50:02 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.107.19.207 with SMTP id 76ls607346iot.4.gmail; Wed, 21 Oct 2015 09:50:02 -0700 (PDT) X-Received: by 10.66.227.166 with SMTP id sb6mr8558515pac.0.1445446202228; Wed, 21 Oct 2015 09:50:02 -0700 (PDT) Return-Path: Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com. [2607:f8b0:400e:c03::230]) by gmr-mx.google.com with ESMTPS id ce6si1213896pad.0.2015.10.21.09.50.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2015 09:50:02 -0700 (PDT) Received-SPF: pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c03::230 as permitted sender) client-ip=2607:f8b0:400e:c03::230; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c03::230 as permitted sender) smtp.mailfrom=navyasri.tech@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com Received: by mail-pa0-x230.google.com with SMTP id hk11so59612957pad.1 for ; Wed, 21 Oct 2015 09:50:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=pugOCHaKQpLcx5OW6MlLCpb9+NPI1QvjHU5lFHaFNuA=; b=ZfWkgKnsTq6Q1EvesrHi8wCl3EV1FcwH55sTK2m+klBPspZ4HNiwJi1c4paukaUWdF 2QllnAn4TJY6J8cThYZ2GNEqKfjrOi3cJuTUyoAa7g4dCiI2J/oaZr4WkavDIqLYsGfU ck6ZrwQl87ykauOMmUky56k+KsRyYj6PYuuGru/J4Fca4pbAlqm6U57buuJbgIwxn8ML dgpL9DdGrktRXPxbmipsBkndxsXTFGkbxzbxVHXOzkUIlT3PRqAb9wXsKIk/5zejmcRc JHpRgwdZwvOglJsyt7nqzV/7xQmvCvklOrukVeSQniyktmLxrcuDPQsgwlYKF8huHF6S 0K2A== X-Received: by 10.68.179.33 with SMTP id dd1mr11802647pbc.134.1445446202139; Wed, 21 Oct 2015 09:50:02 -0700 (PDT) Return-Path: Received: from navya ([27.6.33.173]) by smtp.gmail.com with ESMTPSA id g12sm10075875pat.36.2015.10.21.09.50.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Oct 2015 09:50:01 -0700 (PDT) Date: Wed, 21 Oct 2015 22:20:04 +0530 From: Navya Sri Nizamkari To: outreachy-kernel@googlegroups.com Cc: outreachy-kernel@googlegroups.com Subject: [PATCH 3/5] Staging: xgifb: Remove extra blank lines. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) This patch fixes the checkpatch.pl check: CHECK: Please don't use multiple blank lines Signed-off-by: Navya Sri Nizamkari --- drivers/staging/xgifb/vb_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index 2eee3ac..1aa8600 100644 --- a/drivers/staging/xgifb/vb_init.c +++ b/drivers/staging/xgifb/vb_init.c @@ -498,7 +498,6 @@ static void XGINew_SetDRAMDefaultRegister340( xgifb_reg_set(P3c4, 0x1B, 0x03); /* SR1B */ } - static unsigned short XGINew_SetDRAMSize20Reg( unsigned short dram_size, struct vb_device_info *pVBInfo) -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6208143559134019584 X-Received: by 10.182.120.231 with SMTP id lf7mr8258020obb.50.1445446166512; Wed, 21 Oct 2015 09:49:26 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.182.28.165 with SMTP id c5ls504399obh.96.gmail; Wed, 21 Oct 2015 09:49:26 -0700 (PDT) X-Received: by 10.182.240.202 with SMTP id wc10mr9050455obc.9.1445446166258; Wed, 21 Oct 2015 09:49:26 -0700 (PDT) Return-Path: Received: from mail-pa0-x235.google.com (mail-pa0-x235.google.com. [2607:f8b0:400e:c03::235]) by gmr-mx.google.com with ESMTPS id el2si1178144pbb.0.2015.10.21.09.49.26 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2015 09:49:26 -0700 (PDT) Received-SPF: pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c03::235 as permitted sender) client-ip=2607:f8b0:400e:c03::235; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c03::235 as permitted sender) smtp.mailfrom=navyasri.tech@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com Received: by mail-pa0-x235.google.com with SMTP id fv9so61901375pac.3 for ; Wed, 21 Oct 2015 09:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=6eGxs1I8Ja31xMelz6DyFq1L+XjYFNgxoi9TOKKUinA=; b=bN+bBNXkAIgu+ic7fQ6Rb7njSLUtfZ++6hxMceOTgqrkc49kt29uJzney/lTzlj3uJ GD02DBs6HZADLOVtOHqE4vmu5jx2VXBYGqTEBBK/tC3yGiNklw6qPvSf+YFuqdmdxLv+ wtq3femBwMCmtRcA1ed9jktNTUkM86cXDW37V28pQBt1T8/SjYtp6I2r5Mde3LuHXmVt Qwu10xNhGcc2VP7VyVZcZRg4kXq+hHLE6QzlUiQvT7HPe1cU2Ok6c+wSsY8qmNCFj9Dh VFL66WF1QN7N7ET6mXKBssFyMA6rUXmYW8U1rZe0s0EcxyZKyNS+nWWQMhZNui95d6ro 8nfQ== X-Received: by 10.68.65.37 with SMTP id u5mr11567888pbs.76.1445446166119; Wed, 21 Oct 2015 09:49:26 -0700 (PDT) Return-Path: Received: from navya ([27.6.33.173]) by smtp.gmail.com with ESMTPSA id ez1sm10068492pab.6.2015.10.21.09.49.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Oct 2015 09:49:25 -0700 (PDT) Date: Wed, 21 Oct 2015 22:19:28 +0530 From: Navya Sri Nizamkari To: outreachy-kernel@googlegroups.com Cc: outreachy-kernel@googlegroups.com Subject: [PATCH 2/5] Staging: xgifb: Remove blank line before } and after { Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Remove blank line after { and before }. Problem found using checkpatch. Signed-off-by: Navya Sri Nizamkari --- drivers/staging/xgifb/vb_init.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index 6204a98..2eee3ac 100644 --- a/drivers/staging/xgifb/vb_init.c +++ b/drivers/staging/xgifb/vb_init.c @@ -195,7 +195,6 @@ static void XGINew_DDRII_Bootup_XG27( /* Set SR1B refresh control 000:close; 010:open */ xgifb_reg_set(P3c4, 0x1B, 0x04); usleep_range(200); - } static void XGINew_DDR2_MRS_XG20(struct xgi_hw_device_info *HwDeviceExtension, @@ -1059,7 +1058,6 @@ static void XGINew_SetModeScratch(struct vb_device_info *pVBInfo) CR38Data &= ~SetYPbPr; CR38Data |= tempch; xgifb_reg_set(pVBInfo->P3d4, 0x38, CR38Data); - } static unsigned short XGINew_SenseLCD(struct xgi_hw_device_info @@ -1134,7 +1132,6 @@ static void XGINew_GetXG27Sense(struct vb_device_info *pVBInfo) xgifb_reg_and_or(pVBInfo->P3d4, 0x38, ~0xE0, 0xA0); } xgifb_reg_or(pVBInfo->P3d4, 0x32, LCDSense); - } static unsigned char GetXG21FPBits(struct vb_device_info *pVBInfo) @@ -1329,14 +1326,12 @@ unsigned char XGIInitNew(struct pci_dev *pdev) XGI_SenseCRT1(pVBInfo); if (HwDeviceExtension->jChipType == XG21) { - xgifb_reg_and_or(pVBInfo->P3d4, 0x32, ~Monitor1Sense, Monitor1Sense); /* Z9 default has CRT */ temp = GetXG21FPBits(pVBInfo); xgifb_reg_and_or(pVBInfo->P3d4, 0x37, ~0x01, temp); - } if (HwDeviceExtension->jChipType == XG27) { xgifb_reg_and_or(pVBInfo->P3d4, -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6208143559134019584 X-Received: by 10.140.165.83 with SMTP id l80mr8525379qhl.14.1445446135533; Wed, 21 Oct 2015 09:48:55 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.107.10.226 with SMTP id 95ls496527iok.1.gmail; Wed, 21 Oct 2015 09:48:55 -0700 (PDT) X-Received: by 10.50.110.6 with SMTP id hw6mr2620098igb.7.1445446135186; Wed, 21 Oct 2015 09:48:55 -0700 (PDT) Return-Path: Received: from mail-pa0-x235.google.com (mail-pa0-x235.google.com. [2607:f8b0:400e:c03::235]) by gmr-mx.google.com with ESMTPS id el2si1178144pbb.0.2015.10.21.09.48.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2015 09:48:55 -0700 (PDT) Received-SPF: pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c03::235 as permitted sender) client-ip=2607:f8b0:400e:c03::235; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c03::235 as permitted sender) smtp.mailfrom=navyasri.tech@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com Received: by mail-pa0-x235.google.com with SMTP id fv9so61901375pac.3 for ; Wed, 21 Oct 2015 09:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=s4avXzrMwsSDtzJ7S+L38xuYxyhLJDO810rJtQ2HAUI=; b=U31JHYrxHbenP7H3Vzi+o5HvwFCgAfAYecdMjdJ2XcfJXFNmq056WHe69W3Ks2v/8X ciigD6DFv15I2cZGkVRcWJPw+WY/l/KnlOr5wvwqWRsljQucxYZZghwwU37eb+tM6wMQ 16MpqS9ld8oosePIjazOZCDEBOv+R5OTU8VWorRJdwmmOHijiQOAB5zv7Nw5kp7szWBu HbDwguJWR+Tg4hbEih7YZNeC6fvVHel465G6gx08edOkFL83az81v+oLqolZ+nQiXZLl 1EDVRpUzgB+jOUlZgFvZV6E+hnR0MUKaaVidFU4MnjvOIPOFFiqy7oh7Nny68GQcS9f0 fL0g== X-Received: by 10.68.240.2 with SMTP id vw2mr11579590pbc.41.1445446135067; Wed, 21 Oct 2015 09:48:55 -0700 (PDT) Return-Path: Received: from navya ([27.6.33.173]) by smtp.gmail.com with ESMTPSA id ip7sm3277932pbd.49.2015.10.21.09.48.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Oct 2015 09:48:54 -0700 (PDT) Date: Wed, 21 Oct 2015 22:18:57 +0530 From: Navya Sri Nizamkari To: outreachy-kernel@googlegroups.com Cc: outreachy-kernel@googlegroups.com Subject: [PATCH 1/5] Staging: xgifb: Add space between ; and variable name Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) This patch fixes the checkpatch.pl error: ERROR: space required after that ';' Signed-off-by: Navya Sri Nizamkari --- drivers/staging/xgifb/vb_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index ea358a0..6204a98 100644 --- a/drivers/staging/xgifb/vb_init.c +++ b/drivers/staging/xgifb/vb_init.c @@ -10,7 +10,7 @@ static const unsigned short XGINew_DDRDRAM_TYPE340[4][2] = { { 16, 0x45}, { 8, 0x35}, { 4, 0x31}, - { 2, 0x21} };e + { 2, 0x21} }; e static const unsigned short XGINew_DDRDRAM_TYPE20[12][2] = { { 128, 0x5D}, -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6208143559134019584 X-Received: by 10.66.194.166 with SMTP id hx6mr8793008pac.37.1445446060007; Wed, 21 Oct 2015 09:47:40 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.182.33.135 with SMTP id r7ls469629obi.84.gmail; Wed, 21 Oct 2015 09:47:39 -0700 (PDT) X-Received: by 10.182.52.132 with SMTP id t4mr8679582obo.16.1445446059446; Wed, 21 Oct 2015 09:47:39 -0700 (PDT) Return-Path: Received: from mail-pa0-x22c.google.com (mail-pa0-x22c.google.com. [2607:f8b0:400e:c03::22c]) by gmr-mx.google.com with ESMTPS id ce6si1213075pad.0.2015.10.21.09.47.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2015 09:47:39 -0700 (PDT) Received-SPF: pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c03::22c as permitted sender) client-ip=2607:f8b0:400e:c03::22c; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c03::22c as permitted sender) smtp.mailfrom=navyasri.tech@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com Received: by mail-pa0-x22c.google.com with SMTP id rc13so59485343pab.0 for ; Wed, 21 Oct 2015 09:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=oVTt0mOQaWIcJw/6EWKFGbodqVayUSJQRAGyKfpQoVI=; b=bfw+JlaTdZEBrrP5GZ8PV/KbK01CvgqYkmDlu6T8AA8HZLu6xeNHj3BXVV5biuxWRU 6hbktQYjmj7IrJie6pjePsNks7QEqa4oPmfftWt7/SjWdx929hbTkrFaFJbHSa52RG8e mvj718j88qvgcsC3rF7JUkR72qcPcTjQFCmYCliAs+A6wWoUEGI/Oi2UajXirnhxYgqb WxyVqSRC4yk43ErtCTk1vDZm4HtLEqiRAe4kiKa3SHQilW6uUNoiJVt6DDcQF8/rqWCd V7/iKuMX/iKAD2V+qnPE+7vc75rIqB9tDE9fKQ/Th2bvcEPS6czMArR9SlPkHY1wYlLC /tzg== X-Received: by 10.68.222.163 with SMTP id qn3mr11902019pbc.54.1445446059271; Wed, 21 Oct 2015 09:47:39 -0700 (PDT) Return-Path: Received: from navya ([27.6.33.173]) by smtp.gmail.com with ESMTPSA id sz9sm10068962pab.13.2015.10.21.09.47.38 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Oct 2015 09:47:38 -0700 (PDT) Date: Wed, 21 Oct 2015 22:17:41 +0530 From: Navya Sri Nizamkari To: outreachy-kernel@googlegroups.com Cc: outreachy-kernel@googlegroups.com Subject: [PATCH 0/5] Improve code, codestyle in xgifb. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) This patchset clears checkpatch warnings in vb_init such as: space required after that ';', remove blank lines after {, remove blank lines before }, remove multiple balnk lines, comparison with NULL, space required after that ';'. Navya Sri Nizamkari (5): Staging: xgifb: Add space between ; and variable name Staging: xgifb: Remove blank line before } and after { Staging: xgifb: Remove extra blnk lines. Staging: xgifb: Fix comparison to NULL warning Staging: xgifb: Remove space after cast drivers/staging/xgifb/vb_init.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) -- 1.9.1