From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQPqK-0000ar-IW for qemu-devel@nongnu.org; Mon, 01 Feb 2016 20:33:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQPqJ-0004pB-MK for qemu-devel@nongnu.org; Mon, 01 Feb 2016 20:33:20 -0500 From: Jeff Cody Date: Mon, 1 Feb 2016 20:33:09 -0500 Message-Id: Subject: [Qemu-devel] [PATCH v2 0/2] Active commit regression fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Changes from v1: * Rather than allow insertion when bs->device_listtqe_prev points to a NULL entry, make sure than we follow the block scheme of enforcing bs->device_list->tqe_prev is NULL upon deletion. (Thanks Max!) Bug #1300209 is a regression in 2.5, introduced during the change away from bdrv_swap(). When we change the parent backing link (change_parent_backing_link), we must also accomodate non-NULL tqe_prev pointers that point to a NULL entry. Please see patch #1 for more details. Jeff Cody (2): block: set device_list.tqe_prev to NULL on BDS removal block: qemu-iotests - add test for snapshot, commit, snapshot bug block.c | 24 ++++++---- blockdev.c | 3 +- include/block/block.h | 1 + tests/qemu-iotests/143 | 114 +++++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/143.out | 24 ++++++++++ tests/qemu-iotests/group | 1 + 6 files changed, 155 insertions(+), 12 deletions(-) create mode 100755 tests/qemu-iotests/143 create mode 100644 tests/qemu-iotests/143.out -- 1.9.3