From: Svetlana Orlik <sveta.orlik.code@gmail.com>
To: outreachy-kernel@googlegroups.com
Subject: [PATCH 0/6] staging: iio: accel: Fix checkpatch warnings, unify style, improve readability
Date: Tue, 22 Mar 2016 18:05:53 +0300 [thread overview]
Message-ID: <cover.1458656755.git.sveta.orlik.code@gmail.com> (raw)
Some of the .h files got many 'line over 80 characters' checkpatch warnings
because of this commenting style:
#define ADIS16201_DIAG_STAT_ALARM2 BIT(9) /* Alarm 2 status: 1 = alarm active, 0 = alarm inactive */
#define ADIS16201_DIAG_STAT_ALARM1 BIT(8) /* Alarm 1 status: 1 = alarm active, 0 = alarm inactive */
Some other .h files have obviously been already corrected
by moving comment into line before #define, but interlacing
of comment and #defile lines with no space between them made
hard to read code like this:
/* Output, temperature */
#define ADIS16209_TEMP_OUT 0x0A
/* Output, x-axis inclination */
#define ADIS16209_XINCL_OUT 0x0C
/* Output, y-axis inclination */
#define ADIS16209_YINCL_OUT 0x0E
/* Output, +/-180 vertical rotational position */
#define ADIS16209_ROT_OUT 0x10
/* Calibration, x-axis acceleration offset null */
#define ADIS16209_XACCL_NULL 0x12
This patches move comments to line before #define where it is not done yet
(and where it is appropriate).
It helps to get rid of 'line over 80 characters' warnings and to unify code style.
Also, blank line is added after each #define-comment group and each
section title comment to improve readability of code.
Svetlana Orlik (6):
staging: iio: accel: adis16204: Fix 'line over 80 characters' warning
staging: iio: accel: adis16203: Fix 'line over 80 characters' warning
staging: iio: accel: adis16201: Fix 'line over 80 characters' warning
staging: iio: accel: adis16209: Improve readability
staging: iio: accel: adis16220: Improve readability
staging: iio: accel: adis16240: Improve readability
drivers/staging/iio/accel/adis16201.h | 156 ++++++++++++++++++++++++---------
drivers/staging/iio/accel/adis16203.h | 132 +++++++++++++++++++++-------
drivers/staging/iio/accel/adis16204.h | 159 +++++++++++++++++++++++++---------
drivers/staging/iio/accel/adis16209.h | 39 +++++++++
drivers/staging/iio/accel/adis16220.h | 48 ++++++++++
drivers/staging/iio/accel/adis16240.h | 50 +++++++++++
6 files changed, 471 insertions(+), 113 deletions(-)
--
2.5.0
next reply other threads:[~2016-03-22 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 15:05 Svetlana Orlik [this message]
2016-03-22 15:07 ` [PATCH 1/6] staging: iio: accel: adis16204: Fix 'line over 80 characters' warning Svetlana Orlik
2016-03-22 15:08 ` [PATCH 2/6] staging: iio: accel: adis16203: " Svetlana Orlik
2016-03-22 15:08 ` [PATCH 3/6] staging: iio: accel: adis16201: " Svetlana Orlik
2016-03-22 15:09 ` [PATCH 4/6] staging: iio: accel: adis16209: Improve readability Svetlana Orlik
2016-03-22 15:09 ` [PATCH 5/6] staging: iio: accel: adis16220: " Svetlana Orlik
2016-03-22 15:10 ` [PATCH 6/6] staging: iio: accel: adis16240: " Svetlana Orlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1458656755.git.sveta.orlik.code@gmail.com \
--to=sveta.orlik.code@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.