From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 43BEAE00DDB; Mon, 11 Apr 2016 04:27:37 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [134.134.136.24 listed in list.dnswl.org] Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 0BD34E00C4F for ; Mon, 11 Apr 2016 04:27:34 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 11 Apr 2016 04:27:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,462,1455004800"; d="scan'208";a="929882894" Received: from unknown (HELO lp.ger.corp.intel.com) ([10.252.12.118]) by orsmga001.jf.intel.com with ESMTP; 11 Apr 2016 04:27:32 -0700 From: Elliot Smith To: toaster@yoctoproject.org Date: Mon, 11 Apr 2016 12:27:23 +0100 Message-Id: X-Mailer: git-send-email 1.9.3 Subject: [PATCH 0/4] Validate custom image names correctly X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2016 11:27:37 -0000 We currently validate the name of a new custom image across all projects. This means you can't use the same custom image name in multiple projects. Modify the code to do validation correctly, and add UI tests to verify. To test: 1. Create a project. 2. Create a custom image with name 'goo' in this project; it should work. 3. Try to create another custom image called 'goo' in this project; it should fail. 4. Try to create a custom image called 'core-image-minimal' in this project; it should fail. 5. Create another project. 6. Create a custom image called 'goo' in the second project; it should work. The following changes since commit 4bb6fb30b0d660eaeaf4af134b99b2feaf0b3db2: toaster: fixes for customimage package not found (2016-04-08 09:38:50 +0100) are available in the git repository at: git://git.yoctoproject.org/poky-contrib elliot/toaster/recipe_name_validation-9209 http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/recipe_name_validation-9209 Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=9209 Elliot Smith (4): toaster: only prevent duplicate custom image names within a project toaster: prevent exception when Project.release is null toaster-tests: add tests for new custom image page toaster-tests: make helper click on input before entering text bitbake/lib/toaster/orm/models.py | 16 ++- .../lib/toaster/tests/browser/selenium_helpers.py | 6 +- .../tests/browser/test_new_custom_image_page.py | 160 +++++++++++++++++++++ .../toastergui/static/js/newcustomimage_modal.js | 8 +- bitbake/lib/toaster/toastergui/views.py | 33 +++-- 5 files changed, 200 insertions(+), 23 deletions(-) create mode 100644 bitbake/lib/toaster/tests/browser/test_new_custom_image_page.py -- 1.9.3 --------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.