From: Elliot Smith <elliot.smith@intel.com>
To: toaster@yoctoproject.org
Subject: [PATCH 0/2] Capture command-line builds which fail due to bad targets
Date: Mon, 25 Apr 2016 16:26:07 +0100 [thread overview]
Message-ID: <cover.1461597606.git.elliot.smith@intel.com> (raw)
Toaster currently can't catch build failures which are due to bad targets (e.g.
"bitbake ecky-thump"), as the bitbake run doesn't reach the BuildStarted
event in these cases.
Add a new BuildInit event which fires as soon as buildTargets() or buildFile()
is invoked, and make the build object at this point. When BuildStarted fires,
collect layer information, build variables etc. as previously.
Backwards-compatibility is maintained for jethro by still making a build object
on BuildStarted events. jethro builds which fail early will therefore not be
captured by the new code, but existing functionality should not be broken either.
To test:
1. Start Toaster.
2. On the command-line, run a build with a bad target like "bitbake ecky-thump".
3. The build should register as a failure on the "all builds" page.
The following changes since commit fb8349b97c736d6633b2d79a4003dd86f760bdb1
(toaster-next):
toaster: bin/toaster Fix noweb command (2016-04-21 14:19:05 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib elliot/toaster/failed_builds-8440-v6
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/failed_builds-8440-v6
Elliot Smith (2):
cooker: add BuildInit event
toasterui: use BuildInit to capture builds with bad targets
bitbake/lib/bb/cooker.py | 6 ++++++
bitbake/lib/bb/event.py | 6 +++++-
bitbake/lib/bb/ui/buildinfohelper.py | 17 ++++++++++-------
bitbake/lib/bb/ui/toasterui.py | 19 ++++++++-----------
4 files changed, 29 insertions(+), 19 deletions(-)
--
1.9.3
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next reply other threads:[~2016-04-25 15:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 15:26 Elliot Smith [this message]
2016-04-25 15:26 ` [PATCH 1/2] cooker: add BuildInit event Elliot Smith
2016-04-25 15:26 ` [PATCH 2/2] toasterui: use BuildInit to capture builds with bad targets Elliot Smith
2016-04-28 13:15 ` [PATCH 0/2] Capture command-line builds which fail due to " Barros Pena, Belen
2016-06-09 13:30 ` Michael Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1461597606.git.elliot.smith@intel.com \
--to=elliot.smith@intel.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.