From: Omar Sandoval <osandov@osandov.com>
To: linux-btrfs@vger.kernel.org
Cc: kernel-team@fb.com
Subject: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems
Date: Thu, 14 Jul 2016 16:31:05 -0700 [thread overview]
Message-ID: <cover.1468538030.git.osandov@fb.com> (raw)
From: Omar Sandoval <osandov@fb.com>
So it turns out that the free space tree bitmap handling has always been
broken on big-endian systems. Totally my bad.
Patch 1 fixes this. Technically, it's a disk format change for
big-endian systems, but it never could have worked before, so I won't go
through the trouble of any incompat bits. If you've somehow been using
space_cache=v2 on a big-endian system (I doubt anyone is), you're going
to want to mount with nospace_cache to clear it and wait for this to go
in.
Patch 2 fixes a similar error in the sanity tests (it's the same as the
v2 I posted here [1]) and patch 3 expands the sanity tests to catch the
oversight that patch 1 fixes.
Applies to v4.7-rc7. No regressions in xfstests, and the sanity tests
pass on x86_64 and MIPS.
Thanks!
1: http://thread.gmane.org/gmane.comp.file-systems.btrfs/58329
Omar Sandoval (3):
Btrfs: fix free space tree bitmaps on big-endian systems
Btrfs: fix extent buffer bitmap tests on big-endian systems
Btrfs: expand free space tree sanity tests to catch endianness bug
fs/btrfs/extent_io.c | 64 +++++++++----
fs/btrfs/extent_io.h | 22 +++++
fs/btrfs/free-space-tree.c | 17 ++--
fs/btrfs/tests/extent-io-tests.c | 87 +++++++++--------
fs/btrfs/tests/free-space-tree-tests.c | 164 +++++++++++++++++++--------------
5 files changed, 223 insertions(+), 131 deletions(-)
--
2.9.0
next reply other threads:[~2016-07-14 23:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 23:31 Omar Sandoval [this message]
2016-07-14 23:31 ` [PATCH 1/3] Btrfs: fix free space tree bitmaps on big-endian systems Omar Sandoval
2016-07-14 23:31 ` [PATCH 2/3] Btrfs: fix extent buffer bitmap tests " Omar Sandoval
2016-07-14 23:31 ` [PATCH 3/3] Btrfs: expand free space tree sanity tests to catch endianness bug Omar Sandoval
2016-07-14 23:47 ` [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems Chris Mason
2016-07-15 7:04 ` Chandan Rajendra
2016-07-15 19:15 ` Omar Sandoval
2016-07-17 12:19 ` Chandan Rajendra
2016-07-18 18:43 ` Chris Mason
2016-07-18 22:31 ` Omar Sandoval
2016-07-19 16:06 ` Chandan Rajendra
2016-07-19 19:25 ` Chris Mason
2016-08-18 20:33 ` Omar Sandoval
2016-08-26 11:06 ` Anatoly Pugachev
2016-08-26 11:06 ` Anatoly Pugachev
2016-08-27 0:56 ` Omar Sandoval
2016-08-27 0:56 ` Omar Sandoval
2016-08-27 7:16 ` Anatoly Pugachev
2016-08-27 7:16 ` Anatoly Pugachev
2016-09-21 14:50 ` David Sterba
2016-09-21 17:35 ` Omar Sandoval
2016-07-31 13:04 ` Anatoly Pugachev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1468538030.git.osandov@fb.com \
--to=osandov@osandov.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.