From: Elliot Smith <elliot.smith@intel.com>
To: toaster@yoctoproject.org
Subject: [PATCH 0/2] Revert to default table sort when sort column is hidden
Date: Fri, 22 Jul 2016 09:58:48 +0100 [thread overview]
Message-ID: <cover.1469177705.git.elliot.smith@intel.com> (raw)
Fix an issue where a ToasterTable doesn't revert to the default sort when
the current sort column is hidden.
To test:
1. Run Toaster and do a build.
2. Go to the all builds page. Note that the table is sorted by "Completed on" in reverse order.
3. Use "Edit columns" to switch on the "Started on" column.
4. Sort the table by the "Started on" column. Note that the "Started on" column is highlighted as the sort column.
5. Use "Edit columns" to hide the "Started on" column.
6. Check that the sort goes back to the default ("Completed on" in reverse order).
Related bug:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=9836
The following changes since commit 1826de5234aadb9aa51c83f86471cdd7e88b48cf
(toaster-next):
toaster: loadconf Partially add back some of the layerSource parsing (2016-07-21 11:23:00 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib elliot/toaster/9836-revert_sorting
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/9836-revert_sorting
Elliot Smith (2):
toaster: reset table to default orderby when orderby column is hidden
toaster-tests: add tests for reverting to default sort
.../toaster/tests/browser/test_toastertable_ui.py | 160 +++++++++++++++++++++
bitbake/lib/toaster/toastergui/static/js/table.js | 78 +++++++---
2 files changed, 220 insertions(+), 18 deletions(-)
create mode 100644 bitbake/lib/toaster/tests/browser/test_toastertable_ui.py
--
2.7.4
next reply other threads:[~2016-07-22 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 8:58 Elliot Smith [this message]
2016-07-22 8:58 ` [PATCH 1/2] toaster: reset table to default orderby when orderby column is hidden Elliot Smith
2016-07-22 8:58 ` [PATCH 2/2] toaster-tests: add tests for reverting to default sort Elliot Smith
2016-07-27 10:46 ` [PATCH 0/2] Revert to default table sort when sort column is hidden Barros Pena, Belen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1469177705.git.elliot.smith@intel.com \
--to=elliot.smith@intel.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.