From: Omar Sandoval <osandov@osandov.com>
To: Jens Axboe <axboe@fb.com>, linux-block@vger.kernel.org
Cc: kernel-team@fb.com
Subject: [PATCH v2 00/10] blk-mq: move debugging information from sysfs to debugfs
Date: Wed, 25 Jan 2017 08:06:39 -0800 [thread overview]
Message-ID: <cover.1485360145.git.osandov@fb.com> (raw)
From: Omar Sandoval <osandov@fb.com>
Changes from v1:
- Make the sbitmap seq_file helpers take a (struct sbitmap *) instead of a
(void *), since it's not possible to use them directly as the seq_file
show helper, anyways
- Fix a crash when reading ctx_map because it was attempting to do
exactly that ^
Cover letter from v1:
This series ends our abuse of sysfs and puts all of the debugging information
in debugfs instead. This has a few benefits:
1. Removes the possibility of userspace being stupid and relying on something
in sysfs that we only exposed for debugging.
2. Lifts the limitations of sysfs, including the one-value-per-file convention
and maximum of one page of output.
3. Allows us to add more debugging information that we often want but don't
have when debugging a live system.
Thanks!
Omar
Omar Sandoval (10):
blk-mq: create debugfs directory tree
blk-mq: add hctx->{state,flags} to debugfs
blk-mq: move hctx->dispatch and ctx->rq_list from sysfs to debugfs
blk-mq: add extra request information to debugfs
sbitmap: add helpers for dumping to a seq_file
blk-mq: export software queue pending map to debugfs
blk-mq: move tags and sched_tags info from sysfs to debugfs
blk-mq: add tags and sched_tags bitmaps to debugfs
blk-mq: move hctx io_poll, stats, and dispatched from sysfs to debugfs
blk-mq: move hctx and ctx counters from sysfs to debugfs
block/Makefile | 1 +
block/blk-mq-debugfs.c | 756 ++++++++++++++++++++++++++++++++++++++++++++++++
block/blk-mq-sysfs.c | 248 ++--------------
block/blk-mq-tag.c | 27 --
block/blk-mq-tag.h | 1 -
block/blk-mq.c | 2 +
block/blk-mq.h | 33 +++
include/linux/blkdev.h | 5 +
include/linux/sbitmap.h | 28 ++
lib/sbitmap.c | 74 +++++
10 files changed, 920 insertions(+), 255 deletions(-)
create mode 100644 block/blk-mq-debugfs.c
--
2.11.0
next reply other threads:[~2017-01-25 16:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 16:06 Omar Sandoval [this message]
2017-01-25 16:06 ` [PATCH v2 01/10] blk-mq: create debugfs directory tree Omar Sandoval
2017-01-27 21:56 ` Bart Van Assche
2017-01-25 16:06 ` [PATCH v2 02/10] blk-mq: add hctx->{state,flags} to debugfs Omar Sandoval
2017-01-25 16:06 ` [PATCH v2 03/10] blk-mq: move hctx->dispatch and ctx->rq_list from sysfs " Omar Sandoval
2017-01-27 22:00 ` Bart Van Assche
2017-01-27 22:03 ` Omar Sandoval
2017-01-25 16:06 ` [PATCH v2 04/10] blk-mq: add extra request information " Omar Sandoval
2017-01-25 16:06 ` [PATCH v2 05/10] sbitmap: add helpers for dumping to a seq_file Omar Sandoval
2017-01-25 22:32 ` [PATCH v3 " Omar Sandoval
2017-01-27 22:06 ` Bart Van Assche
2017-01-25 16:06 ` [PATCH v2 06/10] blk-mq: export software queue pending map to debugfs Omar Sandoval
2017-01-25 16:06 ` [PATCH v2 07/10] blk-mq: move tags and sched_tags info from sysfs " Omar Sandoval
2017-01-25 16:06 ` [PATCH v2 08/10] blk-mq: add tags and sched_tags bitmaps " Omar Sandoval
2017-01-25 16:06 ` [PATCH v2 09/10] blk-mq: move hctx io_poll, stats, and dispatched from sysfs " Omar Sandoval
2017-01-25 16:06 ` [PATCH v2 10/10] blk-mq: move hctx and ctx counters " Omar Sandoval
2017-01-27 15:18 ` [PATCH v2 00/10] blk-mq: move debugging information " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1485360145.git.osandov@fb.com \
--to=osandov@osandov.com \
--cc=axboe@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.