From: Benjamin Coddington <bcodding@redhat.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v2 0/4] Skipped unlocks
Date: Fri, 17 Feb 2017 13:46:16 -0500 [thread overview]
Message-ID: <cover.1487356965.git.bcodding@redhat.com> (raw)
Well over a year ago I made other attempts to fix the problem of NFS failing
to send an unlock when signalled. Those attempts were terrible.
Here's another, smaller version that keeps two simple fixes and splits out
the behavior for waiting on I/O completion to be different for the v3 and v4
case. For v4, we can easily ensure the unlock is always sent by having the
rpc_task perform the wait. For v3, that approach would require significant
changes to the way NLM works, so a simpler approach of skipping the wait is
used as was suggested by Trond.
I think this is probably a little late for 4.11. Comments and review are
welcomed.
since v1:
- add Christoph's reviewed-by on 1/4 and 2/4 and fixup switch
indentation on 2/4
Benjamin Coddington (4):
NFS4: remove a redundant lock range check
NFS: Move the flock open mode check into nfs_flock()
locks: Set FL_CLOSE when removing flock locks on close()
NFS: Always wait for I/O completion before unlock
fs/locks.c | 2 +-
fs/nfs/file.c | 31 ++++++++++++++++---------------
fs/nfs/nfs3proc.c | 13 +++++++++++++
fs/nfs/nfs4proc.c | 24 +++++++-----------------
fs/nfs/pagelist.c | 1 +
5 files changed, 38 insertions(+), 33 deletions(-)
--
2.9.3
next reply other threads:[~2017-02-17 18:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 18:46 Benjamin Coddington [this message]
2017-02-17 18:46 ` [PATCH 1/4] NFS4: remove a redundant lock range check Benjamin Coddington
2017-02-17 18:46 ` [PATCH 2/4] NFS: Move the flock open mode check into nfs_flock() Benjamin Coddington
2017-02-17 18:46 ` [PATCH 3/4] locks: Set FL_CLOSE when removing flock locks on close() Benjamin Coddington
2017-02-17 18:46 ` [PATCH 4/4] NFS: Always wait for I/O completion before unlock Benjamin Coddington
2017-02-17 19:00 ` Trond Myklebust
2017-02-17 19:15 ` Benjamin Coddington
2017-02-17 19:30 ` Trond Myklebust
2017-02-17 20:10 ` Benjamin Coddington
2017-02-21 13:56 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1487356965.git.bcodding@redhat.com \
--to=bcodding@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.