All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Coddington <bcodding@redhat.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <anna.schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v3 0/4] Skipped unlocks
Date: Tue, 21 Feb 2017 10:39:13 -0500	[thread overview]
Message-ID: <cover.1487691345.git.bcodding@redhat.com> (raw)

Well over a year ago I made other attempts to fix the problem of NFS failing
to send an unlock when signalled.  Those attempts were terrible.

Here's another, smaller version that keeps two simple fixes and takes the
approach of skipping the wait if FL_CLOSE is set as was suggested by Trond.

I think this is probably a little late for 4.11.  Comments and review are
welcomed.

since v1:
	- add Christoph's reviewed-by on 1/4 and 2/4 and fixup switch
	  indentation on 2/4
since v2:
	- don't sleep in rpciod to wait for I/O completion, just send the unlock
	  immediately for both v3 and v4.

Benjamin Coddington (4):
  NFS4: remove a redundant lock range check
  NFS: Move the flock open mode check into nfs_flock()
  locks: Set FL_CLOSE when removing flock locks on close()
  NFS: Always send an unlock for FL_CLOSE

 fs/locks.c        |  2 +-
 fs/nfs/file.c     | 28 +++++++++++++++++++++-------
 fs/nfs/nfs4proc.c | 17 -----------------
 3 files changed, 22 insertions(+), 25 deletions(-)

-- 
2.9.3


             reply	other threads:[~2017-02-21 15:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 15:39 Benjamin Coddington [this message]
2017-02-21 15:39 ` [PATCH 1/4] NFS4: remove a redundant lock range check Benjamin Coddington
2017-02-21 15:39 ` [PATCH 2/4] NFS: Move the flock open mode check into nfs_flock() Benjamin Coddington
2017-02-22 12:12   ` Jeff Layton
2017-02-21 15:39 ` [PATCH 3/4] locks: Set FL_CLOSE when removing flock locks on close() Benjamin Coddington
2017-02-22 12:13   ` Jeff Layton
2017-02-22 12:25     ` Jeff Layton
2017-02-22 12:25       ` Jeff Layton
2017-02-22 13:25       ` Miklos Szeredi
2017-02-22 13:25         ` Miklos Szeredi
2017-02-22 13:27         ` Benjamin Coddington
2017-02-22 13:27           ` Benjamin Coddington
2017-02-21 15:39 ` [PATCH 4/4] NFS: Always send an unlock for FL_CLOSE Benjamin Coddington
2017-02-22 13:20   ` Jeff Layton
2017-02-22 14:10     ` Benjamin Coddington
2017-02-22 15:42       ` Jeff Layton
2017-02-22 16:27         ` Trond Myklebust
2017-02-22 17:39           ` Benjamin Coddington
2017-02-22 19:20             ` Jeff Layton
2017-02-23 11:24               ` Benjamin Coddington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1487691345.git.bcodding@redhat.com \
    --to=bcodding@redhat.com \
    --cc=anna.schumaker@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.