From: Aishwarya Pant <aishpant@gmail.com>
To: Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com
Cc: outreachy-kernel@googlegroups.com
Subject: [PATCH v2 0/4] staging: bcm2835-audio: fix coding style issues
Date: Tue, 7 Mar 2017 01:16:10 +0530 [thread overview]
Message-ID: <cover.1488829304.git.aishpant@gmail.com> (raw)
This patchset makes the following changes:
- Replace kmalloc and memset with kzalloc
- Replace null return value with PTR_ERR values
- Propagate the PTR_ERR values forward instead of a hardcoded
value for easier debugging
- Replace if (success) else { } after kmalloc with if (error) to
fail fast.
Changes in v2:
- Return error value -EBUSY instead of -1 when queue_work() fails
Aishwarya Pant (4):
staging: bcm2835-audio: Replace kmalloc with kzalloc
staging: bcm2835-audio: replace null with error pointer value
staging: bcm2835-audio: propagate PTR_ERR value instead of -EPERM
staging: bcm2835-audio: use conditional only for error case
.../vc04_services/bcm2835-audio/bcm2835-vchiq.c | 83 +++++++++++-----------
1 file changed, 41 insertions(+), 42 deletions(-)
--
2.7.4
next reply other threads:[~2017-03-06 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 19:46 Aishwarya Pant [this message]
2017-03-06 19:46 ` [PATCH v2 1/4] staging: bcm2835-audio: Replace kmalloc with kzalloc Aishwarya Pant
2017-03-06 19:46 ` [PATCH v2 2/4] staging: bcm2835-audio: replace null with error pointer value Aishwarya Pant
2017-03-06 19:46 ` [PATCH v2 3/4] staging: bcm2835-audio: propagate PTR_ERR value instead of -EPERM Aishwarya Pant
2017-03-06 19:47 ` [PATCH v2 4/4] staging: bcm2835-audio: use conditional only for error case Aishwarya Pant
2017-03-06 21:41 ` [Outreachy kernel] " Julia Lawall
2017-03-07 5:50 ` Aishwarya Pant
2017-03-07 6:31 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1488829304.git.aishpant@gmail.com \
--to=aishpant@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.