* [PATCH v2 0/3] staging: wilc1000: renames multiple camel-cased parameters in wilc methods
@ 2017-03-08 0:26 Tahia Khan
2017-03-08 0:26 ` [PATCH v2 1/3] staging: wilc1000: Fixes camel-casing in wilc_scan_complete_received Tahia Khan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tahia Khan @ 2017-03-08 0:26 UTC (permalink / raw)
To: outreachy-kernel, aditya.shankar, ganesh.krishna, gregkh
Multiple camel-cased parameters renamed in wilc RX buffer
manipulation methods. Originally reported by checkpatch.pl.
Changes since v1: Removing unnecessary linebreak, as
reported by Greg KH <gregkh@linuxfoundation.org>
Tahia Khan (3):
staging: wilc1000: Fixes camel-casing in wilc_scan_complete_received
staging: wilc1000: Fixes camel-casing in wilc_network_info_received
staging: wilc1000: Fixes camel-casing in wilc_gnrl_info_received
drivers/staging/wilc1000/coreconfigurator.h | 9 +++------
drivers/staging/wilc1000/host_interface.c | 27 ++++++++++++---------------
2 files changed, 15 insertions(+), 21 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/3] staging: wilc1000: Fixes camel-casing in wilc_scan_complete_received
2017-03-08 0:26 [PATCH v2 0/3] staging: wilc1000: renames multiple camel-cased parameters in wilc methods Tahia Khan
@ 2017-03-08 0:26 ` Tahia Khan
2017-03-08 0:26 ` [PATCH v2 2/3] staging: wilc1000: Fixes camel-casing in wilc_network_info_received Tahia Khan
2017-03-08 0:26 ` [PATCH v2 3/3] staging: wilc1000: Fixes camel-casing in wilc_gnrl_info_received Tahia Khan
2 siblings, 0 replies; 4+ messages in thread
From: Tahia Khan @ 2017-03-08 0:26 UTC (permalink / raw)
To: outreachy-kernel, aditya.shankar, ganesh.krishna, gregkh
Fixes checkpatch warning by renaming pu8Buffer to buffer
and u32Length to length in wilc_scan_complete_received.
Signed-off-by: Tahia Khan <tahia.khan@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.h | 3 +--
drivers/staging/wilc1000/host_interface.c | 5 ++---
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
index 10101f8..f40d458 100644
--- a/drivers/staging/wilc1000/coreconfigurator.h
+++ b/drivers/staging/wilc1000/coreconfigurator.h
@@ -124,8 +124,7 @@ s32 wilc_parse_network_info(u8 *msg_buffer,
struct network_info **ret_network_info);
s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
struct connect_resp_info **ret_connect_resp_info);
-void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
- u32 u32Length);
+void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer, u32 length);
void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
u32 u32Length);
void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index f848bb8..3eec9dc 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -3523,8 +3523,7 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
mutex_unlock(&hif_deinit_lock);
}
-void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
- u32 u32Length)
+void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer, u32 length)
{
s32 result = 0;
struct host_if_msg msg;
@@ -3532,7 +3531,7 @@ void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
struct host_if_drv *hif_drv = NULL;
struct wilc_vif *vif;
- id = ((pu8Buffer[u32Length - 4]) | (pu8Buffer[u32Length - 3] << 8) | (pu8Buffer[u32Length - 2] << 16) | (pu8Buffer[u32Length - 1] << 24));
+ id = ((buffer[length - 4]) | (buffer[length - 3] << 8) | (buffer[length - 2] << 16) | (buffer[length - 1] << 24));
vif = wilc_get_vif_from_idx(wilc, id);
if (!vif)
return;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/3] staging: wilc1000: Fixes camel-casing in wilc_network_info_received
2017-03-08 0:26 [PATCH v2 0/3] staging: wilc1000: renames multiple camel-cased parameters in wilc methods Tahia Khan
2017-03-08 0:26 ` [PATCH v2 1/3] staging: wilc1000: Fixes camel-casing in wilc_scan_complete_received Tahia Khan
@ 2017-03-08 0:26 ` Tahia Khan
2017-03-08 0:26 ` [PATCH v2 3/3] staging: wilc1000: Fixes camel-casing in wilc_gnrl_info_received Tahia Khan
2 siblings, 0 replies; 4+ messages in thread
From: Tahia Khan @ 2017-03-08 0:26 UTC (permalink / raw)
To: outreachy-kernel, aditya.shankar, ganesh.krishna, gregkh
Fixes checkpatch warning by renaming pu8Buffer to buffer
and u32Length to length in wilc_network_info_received.
Signed-off-by: Tahia Khan <tahia.khan@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.h | 3 +--
drivers/staging/wilc1000/host_interface.c | 11 +++++------
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
index f40d458..45dce5b 100644
--- a/drivers/staging/wilc1000/coreconfigurator.h
+++ b/drivers/staging/wilc1000/coreconfigurator.h
@@ -125,8 +125,7 @@ s32 wilc_parse_network_info(u8 *msg_buffer,
s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
struct connect_resp_info **ret_connect_resp_info);
void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer, u32 length);
-void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
- u32 u32Length);
+void wilc_network_info_received(struct wilc *wilc, u8 *buffer, u32 length);
void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
u32 u32Length);
#endif
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 3eec9dc..ca1990f 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -3442,8 +3442,7 @@ int wilc_deinit(struct wilc_vif *vif)
return result;
}
-void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
- u32 u32Length)
+void wilc_network_info_received(struct wilc *wilc, u8 *buffer, u32 length)
{
s32 result = 0;
struct host_if_msg msg;
@@ -3451,7 +3450,7 @@ void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
struct host_if_drv *hif_drv = NULL;
struct wilc_vif *vif;
- id = ((pu8Buffer[u32Length - 4]) | (pu8Buffer[u32Length - 3] << 8) | (pu8Buffer[u32Length - 2] << 16) | (pu8Buffer[u32Length - 1] << 24));
+ id = ((buffer[length - 4]) | (buffer[length - 3] << 8) | (buffer[length - 2] << 16) | (buffer[length - 1] << 24));
vif = wilc_get_vif_from_idx(wilc, id);
if (!vif)
return;
@@ -3467,9 +3466,9 @@ void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
msg.id = HOST_IF_MSG_RCVD_NTWRK_INFO;
msg.vif = vif;
- msg.body.net_info.len = u32Length;
- msg.body.net_info.buffer = kmalloc(u32Length, GFP_KERNEL);
- memcpy(msg.body.net_info.buffer, pu8Buffer, u32Length);
+ msg.body.net_info.len = length;
+ msg.body.net_info.buffer = kmalloc(length, GFP_KERNEL);
+ memcpy(msg.body.net_info.buffer, buffer, length);
result = wilc_enqueue_cmd(&msg);
if (result)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 3/3] staging: wilc1000: Fixes camel-casing in wilc_gnrl_info_received
2017-03-08 0:26 [PATCH v2 0/3] staging: wilc1000: renames multiple camel-cased parameters in wilc methods Tahia Khan
2017-03-08 0:26 ` [PATCH v2 1/3] staging: wilc1000: Fixes camel-casing in wilc_scan_complete_received Tahia Khan
2017-03-08 0:26 ` [PATCH v2 2/3] staging: wilc1000: Fixes camel-casing in wilc_network_info_received Tahia Khan
@ 2017-03-08 0:26 ` Tahia Khan
2 siblings, 0 replies; 4+ messages in thread
From: Tahia Khan @ 2017-03-08 0:26 UTC (permalink / raw)
To: outreachy-kernel, aditya.shankar, ganesh.krishna, gregkh
Fixes checkpatch warning by renaming pu8Buffer to buffer
and u32Length to length in wilc_gnrl_info_received.
Signed-off-by: Tahia Khan <tahia.khan@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.h | 3 +--
drivers/staging/wilc1000/host_interface.c | 11 +++++------
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
index 45dce5b..5256f40 100644
--- a/drivers/staging/wilc1000/coreconfigurator.h
+++ b/drivers/staging/wilc1000/coreconfigurator.h
@@ -126,6 +126,5 @@ s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
struct connect_resp_info **ret_connect_resp_info);
void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer, u32 length);
void wilc_network_info_received(struct wilc *wilc, u8 *buffer, u32 length);
-void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
- u32 u32Length);
+void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *buffer, u32 length);
#endif
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index ca1990f..6aef2b5 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -3475,8 +3475,7 @@ void wilc_network_info_received(struct wilc *wilc, u8 *buffer, u32 length)
netdev_err(vif->ndev, "message parameters (%d)\n", result);
}
-void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
- u32 u32Length)
+void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *buffer, u32 length)
{
s32 result = 0;
struct host_if_msg msg;
@@ -3486,7 +3485,7 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
mutex_lock(&hif_deinit_lock);
- id = ((pu8Buffer[u32Length - 4]) | (pu8Buffer[u32Length - 3] << 8) | (pu8Buffer[u32Length - 2] << 16) | (pu8Buffer[u32Length - 1] << 24));
+ id = ((buffer[length - 4]) | (buffer[length - 3] << 8) | (buffer[length - 2] << 16) | (buffer[length - 1] << 24));
vif = wilc_get_vif_from_idx(wilc, id);
if (!vif) {
mutex_unlock(&hif_deinit_lock);
@@ -3511,9 +3510,9 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
msg.id = HOST_IF_MSG_RCVD_GNRL_ASYNC_INFO;
msg.vif = vif;
- msg.body.async_info.len = u32Length;
- msg.body.async_info.buffer = kmalloc(u32Length, GFP_KERNEL);
- memcpy(msg.body.async_info.buffer, pu8Buffer, u32Length);
+ msg.body.async_info.len = length;
+ msg.body.async_info.buffer = kmalloc(length, GFP_KERNEL);
+ memcpy(msg.body.async_info.buffer, buffer, length);
result = wilc_enqueue_cmd(&msg);
if (result)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-08 0:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-08 0:26 [PATCH v2 0/3] staging: wilc1000: renames multiple camel-cased parameters in wilc methods Tahia Khan
2017-03-08 0:26 ` [PATCH v2 1/3] staging: wilc1000: Fixes camel-casing in wilc_scan_complete_received Tahia Khan
2017-03-08 0:26 ` [PATCH v2 2/3] staging: wilc1000: Fixes camel-casing in wilc_network_info_received Tahia Khan
2017-03-08 0:26 ` [PATCH v2 3/3] staging: wilc1000: Fixes camel-casing in wilc_gnrl_info_received Tahia Khan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.