[PATCH v4 0/8] staging: bcm2835-audio: fix coding style issues

[Aishwarya Pant <aishpant@gmail.com>]

This patch has the following fixes:

-- Replace kmalloc and memset with kzalloc vc_vchi_audio_init(..)
-- Replace null return value with PTR_ERR(..) values in
   vc_vchi_audio_init(..)
-- Propagate the PTR_ERR values forward instead of a hardcoded
   value for easier debugging in bcm2835_audio_open_connection(..)
-- Replace if (success) else { } after kmalloc with if(error)
   to fail fast in the work function
-- De-allocate 'work' when queue_work(..) fails in the work
   functions
-- Add current function names __func__ to debug and error logs in the
   work functions
-- De-allocate 'vchi_instance' when VCHI connection fails or VCHI audio 
   instance initialisation fails in bcm2835_audio_open_connection()
-- Remove BUG_ON() in bcm2835_audio_open_connection()


Changes in v4:
-- Break-up patch 4 into four smaller patches
-- Add a patch proposing removal of BUG_ON()
-- Make the cover letter verbose

Changes in v3:
-- Fix memory leak when queue_work fails
-- Add __func__ to debug logs

Changes in v2:
-- Return error value -EBUSY instead of -1 when queue_work()
   fails


Aishwarya Pant (8):
  staging: bcm2835-audio: Replace kmalloc with kzalloc
  staging: bcm2835-audio: replace null with error pointer value
  staging: bcm2835-audio: propagate PTR_ERR value instead of -EPERM
  staging: bcm2835-audio: use conditional only for error case
  staging: bcm2835-audio: deallocate work when queue_work(...) fails
  staging: bcm2835-audio: Add function name to debug and error logs
  staging: bcm2835-audio: fix memory leak in    
    bcm2835_audio_open_connection()
  staging: bcm2835-audio: remove BUG_ON() in
    bcm2835_audio_open_connection()

 .../vc04_services/bcm2835-audio/bcm2835-vchiq.c    | 109 +++++++++++----------
 1 file changed, 56 insertions(+), 53 deletions(-)

-- 
2.7.4