All of lore.kernel.org
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: linux-block@vger.kernel.org
Cc: kernel-team@fb.com
Subject: [PATCH 0/4] block: callback-based statistics
Date: Tue, 14 Mar 2017 14:03:27 -0700	[thread overview]
Message-ID: <cover.1489524591.git.osandov@fb.com> (raw)

From: Omar Sandoval <osandov@fb.com>

This patchset generalizes the blk-stats infrastructure to allow users to
register a callback to be called at a given time with the statistics of
requests completed during that window. Writeback throttling and hybrid
polling are converted to the new infrastructure. The ultimate goal is to
use this infrastructure for the mq I/O scheduler.

The details are in patch 4, which is the actual conversion. Patches 1-3
are preparation cleanups.

A couple of minor open issues:

- Since there is no single source of truth for stats anymore (it's
  per-callback now), I got rid of the sysfs/debugfs files. If we still
  want these, we could potentially expose the statistics that poll is
  using.
- Polling used to use per-hctx stats, but now the stats are gathered to
  a per-request_queue cache. This might make the stats noisier, but we
  can improve this in the future by splitting out stats by request size
  or something like that.

Omar Sandoval (4):
  block: tear out blk-stat debugfs/sysfs entries
  block: remove extra calls to wbt_exit()
  block: change stats from array type to struct type
  blk-stats: convert to callback-based statistics reporting

 block/blk-core.c           |   7 +-
 block/blk-mq-debugfs.c     |  55 ---------
 block/blk-mq.c             |  79 ++++++++----
 block/blk-mq.h             |   1 -
 block/blk-stat.c           | 300 ++++++++++++++++++++-------------------------
 block/blk-stat.h           |  98 ++++++++++++---
 block/blk-sysfs.c          |  31 +----
 block/blk-wbt.c            |  66 +++++-----
 block/blk-wbt.h            |   2 +-
 include/linux/blk_types.h  |   8 +-
 include/linux/blkdev.h     |  10 +-
 include/trace/events/wbt.h |  20 +--
 12 files changed, 331 insertions(+), 346 deletions(-)

-- 
2.12.0

             reply	other threads:[~2017-03-14 21:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-14 21:03 Omar Sandoval [this message]
2017-03-14 21:03 ` [PATCH 1/4] block: tear out blk-stat debugfs/sysfs entries Omar Sandoval
2017-03-14 21:03 ` [PATCH 2/4] block: remove extra calls to wbt_exit() Omar Sandoval
2017-03-14 21:03 ` [PATCH 3/4] block: change stats from array type to struct type Omar Sandoval
2017-03-14 21:03 ` [PATCH 4/4] blk-stats: convert to callback-based statistics reporting Omar Sandoval
2017-03-14 21:07 ` [PATCH 0/4] block: callback-based statistics Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1489524591.git.osandov@fb.com \
    --to=osandov@osandov.com \
    --cc=kernel-team@fb.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.