From: Johannes Thumshirn <jthumshirn@suse.de>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: James Bottomley <jejb@linux.vnet.ibm.com>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Jinpu Wang <jinpu.wang@profitbricks.com>,
John Garry <john.garry@huawei.com>,
tj@kernel.org, Johannes Thumshirn <jthumshirn@suse.de>
Subject: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs
Date: Fri, 21 Apr 2017 10:04:45 +0200 [thread overview]
Message-ID: <cover.1492760075.git.jthumshirn@suse.de> (raw)
This series re-orders the calls to scsi_remove_host() and sas_remove_host() in
all SAS HBA drivers (apart from mpt3sas which is doing it correctly). This is
for two reasons:
1) After the change to recursive removal of sysfs entries, we're
trying to remove already removed kobjects when doing a
sas_remove_host() _after_ a scsi_remove_host()
2) the documentation mandates it even (becuase of 1)
Unfortunately this does not completely solve issues with recursive sysfs
removals in SAS, as libsas has asynchronous behaviour where strong ordering
would be needed. But I am working on it and I do know other do as well. So if
anyone else (James, Christoph, Bart, I'm looking at you) has an idea, I do
have test setups and I'm willing to take input in form of ideas and patches.
I also dropped the SDEV_CANCEL state change for now. We re-evaluate it once we
have an idea how to tackle the ordering issues and place it into
sas_unregister_ha() as per James' comment.
Thanks,
Johannes
Johannes Thumshirn (5):
scsi: isci: remove the SAS host after the SCSI host
aic94xx: remove the SAS host after the SCSI host
scsi: hisi_sas: remove the SAS host after the SCSI host
mvsas: remove the SAS host after the SCSI host
scsi: pm8001: remove the SAS host after the SCSI host
drivers/scsi/aic94xx/aic94xx_init.c | 7 ++++---
drivers/scsi/hisi_sas/hisi_sas_main.c | 4 ++--
drivers/scsi/isci/init.c | 3 ++-
drivers/scsi/mvsas/mv_init.c | 6 ++++--
drivers/scsi/pm8001/pm8001_init.c | 8 ++++++--
5 files changed, 18 insertions(+), 10 deletions(-)
--
2.12.0
next reply other threads:[~2017-04-21 8:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 8:04 Johannes Thumshirn [this message]
2017-04-21 8:04 ` [PATCH v2 1/5] scsi: isci: remove the SAS host after the SCSI host Johannes Thumshirn
2017-04-21 8:04 ` [PATCH v2 2/5] aic94xx: " Johannes Thumshirn
2017-04-21 8:04 ` [PATCH v2 3/5] scsi: hisi_sas: " Johannes Thumshirn
2017-04-21 8:04 ` [PATCH v2 4/5] mvsas: " Johannes Thumshirn
2017-04-21 8:04 ` [PATCH v2 5/5] scsi: pm8001: " Johannes Thumshirn
2017-04-21 8:34 ` [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs John Garry
2017-04-21 8:34 ` John Garry
2017-04-21 8:39 ` Johannes Thumshirn
2017-04-21 8:57 ` John Garry
2017-04-21 8:57 ` John Garry
2017-04-21 11:20 ` Christoph Hellwig
2017-04-21 11:54 ` John Garry
2017-04-21 11:54 ` John Garry
2017-04-22 0:29 ` wangyijing
2017-04-22 0:29 ` wangyijing
2017-04-21 11:19 ` Christoph Hellwig
2017-04-21 11:22 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1492760075.git.jthumshirn@suse.de \
--to=jthumshirn@suse.de \
--cc=Bart.VanAssche@sandisk.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jinpu.wang@profitbricks.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.