All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Stevenson <dave.stevenson@raspberrypi.org>
To: linux-media@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-rpi-kernel@lists.infradead.org
Cc: Dave Stevenson <dave.stevenson@raspberrypi.org>
Subject: [RFC 0/2] BCM283x Camera Receiver driver
Date: Wed, 14 Jun 2017 16:15:45 +0100	[thread overview]
Message-ID: <cover.1497452006.git.dave.stevenson@raspberrypi.org> (raw)

Hi All.

This is adding a V4L2 subdevice driver for the CSI2/CCP2 camera
receiver peripheral on BCM283x, as used on Raspberry Pi.

v4l2-compliance results depend on the sensor subdevice this is
connected to. It passes the basic tests cleanly with TC358743,
but objects with OV5647
fail: v4l2-test-controls.cpp(574): g_ext_ctrls does not support count == 0
Neither OV5647 nor Unicam support any controls.

I must admit to not having got OV5647 to stream with the current driver
register settings. It works with a set of register settings for VGA RAW10.
I also have a couple of patches pending for OV5647, but would like to
understand the issues better before sending them out.

Two queries I do have in V4L2-land:
- When s_dv_timings or s_std is called, is the format meant to
  be updated automatically? Even if we're already streaming?
  Some existing drivers seem to, but others don't.
- With s_fmt, is sizeimage settable by the application in the same
  way as bytesperline? yavta allows you to specify it on the command
  line, whilst v4l2-ctl doesn't. Some of the other parts of the Pi
  firmware have a requirement that the buffer is a multiple of 16 lines
  high, which can be matched by V4L2 if we can over-allocate the
  buffers by the app specifying sizeimage. But if I allow that,
  then I get a v4l2-compliance failure as the size doesn't get
  reset when switching from RGB3 to UYVY as it takes the request as
  a request to over-allocate.

Apologies if I've messed up in sending these patches - so many ways
to do something.

Thanks in advance.
  Dave

Dave Stevenson (2):
  [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver
  [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

 .../devicetree/bindings/media/bcm2835-unicam.txt   |   76 +
 drivers/media/platform/Kconfig                     |    1 +
 drivers/media/platform/Makefile                    |    2 +
 drivers/media/platform/bcm2835/Kconfig             |   14 +
 drivers/media/platform/bcm2835/Makefile            |    3 +
 drivers/media/platform/bcm2835/bcm2835-unicam.c    | 2100 ++++++++++++++++++++
 drivers/media/platform/bcm2835/vc4-regs-unicam.h   |  257 +++
 7 files changed, 2453 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/bcm2835-unicam.txt
 create mode 100644 drivers/media/platform/bcm2835/Kconfig
 create mode 100644 drivers/media/platform/bcm2835/Makefile
 create mode 100644 drivers/media/platform/bcm2835/bcm2835-unicam.c
 create mode 100644 drivers/media/platform/bcm2835/vc4-regs-unicam.h

-- 
2.7.4

             reply	other threads:[~2017-06-14 15:16 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14 15:15 Dave Stevenson [this message]
2017-06-14 15:15 ` [RFC 1/2] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver Dave Stevenson
2017-06-15  6:34   ` Stefan Wahren
2017-06-15 12:35     ` Dave Stevenson
2017-06-15 12:59   ` Sakari Ailus
2017-06-15 16:15     ` Dave Stevenson
2017-06-16  9:57       ` Sakari Ailus
2017-06-16 14:40         ` Dave Stevenson
2017-06-16 20:57           ` Sakari Ailus
2017-06-14 15:15 ` [RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface Dave Stevenson
2017-06-15  7:12   ` Hans Verkuil
2017-06-15  7:20     ` Stefan Wahren
2017-06-15 13:38     ` Dave Stevenson
2017-06-15 14:14       ` Hans Verkuil
2017-06-15 15:11         ` Dave Stevenson
2017-06-16 14:05           ` Hans Verkuil
2017-06-16 15:55             ` Dave Stevenson
2017-06-16 16:08               ` Hans Verkuil
2017-06-16 16:47                 ` Dave Stevenson
2017-06-15 14:49       ` Stefan Wahren
2017-06-15 15:40         ` Dave Stevenson
2017-06-14 15:42 ` [RFC 0/2] BCM283x Camera Receiver driver Hans Verkuil
2017-06-14 16:29   ` Dave Stevenson
2017-06-14 17:38     ` Hans Verkuil
2017-06-14 21:03       ` Dave Stevenson
2017-06-15  7:17         ` Hans Verkuil
2017-06-15 12:29           ` Dave Stevenson
2017-06-15 12:30             ` Hans Verkuil
2017-08-28 14:15 ` Hans Verkuil
2017-08-30  9:40   ` Dave Stevenson
2017-08-30 10:45     ` Hans Verkuil
2017-08-30 11:04       ` Stefan Wahren
2017-08-30 11:04       ` Dave Stevenson
2017-08-30 11:25         ` Hans Verkuil
2017-08-31 14:18         ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1497452006.git.dave.stevenson@raspberrypi.org \
    --to=dave.stevenson@raspberrypi.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.