All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: selinux@tycho.nsa.gov
Subject: [PATCH 0/3] Portability improvements
Date: Tue, 20 Jun 2017 16:07:00 +0200	[thread overview]
Message-ID: <cover.1497967444.git.ps@pks.im> (raw)

Hi,

This is a small batch of portability fixes. It removes calls to
the non-portable getpwent_r function, problems with hardened
toolchains defining FORTIFY_SOURCE and removes usage of
__BEGIN_DECLS. These patches are all aiming for compatibility
with musl on hardened Gentoo.

While I guess that the first two commits of removing
__BEGIN_DECLS and the patch for FORTIFY_SOURCE are
uncontroversial, I can imagine the removal of getpwent_r being a
bit more so due to the alternative being non-reentrant. But to
the best of my knowledge the code in question is not called in a
threaded context, so I actually doubt it matters much. Given that
I'm new to this code base I could very likely be wrong, though.

Patrick


Patrick Steinhardt (3):
  libsepol: replace non-standard use of __BEGIN_DECLS
  libselinux: fix error when FORTIFY_SOURCE is already set
  genhomedircon: avoid use of non-standard `getpwent_r`

 libselinux/src/Makefile                   |  3 ++-
 libselinux/utils/Makefile                 |  3 ++-
 libsemanage/src/genhomedircon.c           | 22 +++++-----------------
 libsepol/include/sepol/ibendport_record.h | 10 +++++++---
 libsepol/include/sepol/ibendports.h       | 11 ++++++++---
 libsepol/include/sepol/ibpkey_record.h    | 11 ++++++++---
 libsepol/include/sepol/ibpkeys.h          | 12 +++++++++---
 7 files changed, 41 insertions(+), 31 deletions(-)

-- 
2.13.1

             reply	other threads:[~2017-06-20 14:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-20 14:07 Patrick Steinhardt [this message]
2017-06-20 14:07 ` [PATCH 1/3] libsepol: replace non-standard use of __BEGIN_DECLS Patrick Steinhardt
2017-06-20 15:05   ` Stephen Smalley
2017-06-20 14:07 ` [PATCH 2/3] libselinux: fix error when FORTIFY_SOURCE is already set Patrick Steinhardt
2017-06-20 15:14   ` Stephen Smalley
2017-06-20 15:29     ` Jason Zaman
2017-06-20 16:01     ` Patrick Steinhardt
2017-06-20 14:07 ` [PATCH 3/3] genhomedircon: avoid use of non-standard `getpwent_r` Patrick Steinhardt
2017-06-20 15:42   ` Stephen Smalley
2017-06-22  9:00     ` Patrick Steinhardt
2017-06-22  9:45 ` [PATCH v2 0/2] Portability improvements Patrick Steinhardt
2017-06-22  9:45   ` [PATCH v2 1/2] libselinux: avoid redefining _FORTIFY_SOURCE Patrick Steinhardt
2017-06-22  9:45   ` [PATCH v2 2/2] genhomedircon: avoid use of non-standard `getpwent_r` Patrick Steinhardt
2017-06-22 20:46     ` Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1497967444.git.ps@pks.im \
    --to=ps@pks.im \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.