From: Alistair Francis <alistair.francis@xilinx.com>
To: qemu-devel@nongnu.org
Cc: alistair.francis@xilinx.com, alistair23@gmail.com,
philippe@mathieu-daude.net, berrange@redhat.com,
armbru@redhat.com
Subject: [Qemu-devel] [RFC v3 0/3] Implement a warning_report function
Date: Wed, 5 Jul 2017 10:36:23 -0700 [thread overview]
Message-ID: <cover.1499276048.git.alistair.francis@xilinx.com> (raw)
QEMU currently has a standard method to report errors with
error_repot(). This ensure a sane and standard format when printing
errors. This series is attempting to extend this functionality for
warnings and information as well.
At the moment only one error is being converted, I wanted to get the
implementation nailed down a little bit before I started converting
others.
This patch renames error_print_loc() function to be more clear, but I
didn't bother renaming the others. It seems silly to change
error_printf() to error_warning_printf() and printf is already taken so
I just left it as is.
I also didn't change the current error output as that would probably
break backwards compatibilty for anyone who is parsing logs.
RFCv3:
- Use more detailed enum and function names
- Add wrapper functions for the info and warning reporting
RFCv2:
- Use enums for ERROR, WARN and INFO with a generic report() function
instead of adding new functions
Alistair Francis (3):
util/qemu-error: Rename error_print_loc() to be more generic
qemu-error: Implement a more generic error reporting
char-socket: Report TCP socket waiting as information
chardev/char-socket.c | 4 +--
include/qemu/error-report.h | 16 +++++++++
scripts/checkpatch.pl | 8 ++++-
util/qemu-error.c | 84 ++++++++++++++++++++++++++++++++++++++++++---
4 files changed, 104 insertions(+), 8 deletions(-)
--
2.11.0
next reply other threads:[~2017-07-05 17:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 17:36 Alistair Francis [this message]
2017-07-05 17:36 ` [Qemu-devel] [RFC v3 1/3] util/qemu-error: Rename error_print_loc() to be more generic Alistair Francis
2017-07-06 2:36 ` Thomas Huth
2017-07-05 17:36 ` [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting Alistair Francis
2017-07-06 2:42 ` Thomas Huth
2017-07-06 6:15 ` Markus Armbruster
2017-07-06 8:07 ` Daniel P. Berrange
2017-07-06 11:27 ` Markus Armbruster
2017-07-06 11:45 ` Daniel P. Berrange
2017-07-06 12:20 ` Markus Armbruster
2017-07-06 13:10 ` Daniel P. Berrange
2017-07-06 14:44 ` Markus Armbruster
2017-07-06 18:45 ` Alistair Francis
2017-07-05 17:36 ` [Qemu-devel] [RFC v3 3/3] char-socket: Report TCP socket waiting as information Alistair Francis
2017-07-06 2:46 ` Thomas Huth
2017-07-06 6:18 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1499276048.git.alistair.francis@xilinx.com \
--to=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=philippe@mathieu-daude.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.