From: Gaetan Rivet <gaetan.rivet@6wind.com>
To: dev@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>,
Thomas Monjalon <thomas@monjalon.net>,
Shachar Beiser <shacharbe@mellanox.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: [PATCH v2 0/6] fix ethdev device detach
Date: Wed, 26 Jul 2017 15:35:51 +0200 [thread overview]
Message-ID: <cover.1501076035.git.gaetan.rivet@6wind.com> (raw)
In-Reply-To: <cover.1501075226.git.gaetan.rivet@6wind.com>
Device detach in librte_ether is rough right now.
- Device hotplug capability is not properly checked
- Device state should be set after a successful detach
- MLX drivers are lacking the relevant flag
- And this flag should actually be removed, thus occuring an API change
for v17.11. An announce follows.
Without this series on an MLX4 port:
testpmd> port close 0
Closing ports...
Port 0 is now not stopped
Done
testpmd> port stop 0
Stopping ports...
Checking link statuses...
Done
testpmd> port close 0
Closing ports...
Done
testpmd> port detach 0
Detaching a port...
testpmd> show port info 0
Segmentation fault (core dumped)
With this series:
testpmd> port stop 0
Stopping ports...
Checking link statuses...
Done
testpmd> port detach 0
Detaching a port...
Please close port first
testpmd> port close 0
Closing ports...
Done
testpmd> port detach 0
Detaching a port...
Port '00:03.0' is detached. Now total ports is 0
Done
testpmd> show port info 0
Invalid port 0
Valid port range is [0]
v2:
- remove coredump from patchset
Gaetan Rivet (6):
ethdev: fix device state on detach
ethdev: properly check detach capability
net/mlx4: advertize the detach capability
net/mlx5: advertize the detach capability
app/testpmd: let the user know device detach failed
doc: announce ethdev API change for detach flag
app/test-pmd/testpmd.c | 9 ++++++---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
drivers/net/mlx4/mlx4.c | 1 +
drivers/net/mlx5/mlx5.c | 1 +
lib/librte_ether/rte_ethdev.c | 11 +----------
5 files changed, 15 insertions(+), 13 deletions(-)
--
2.1.4
next prev parent reply other threads:[~2017-07-26 13:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 5:43 [PATCH] net/mlx5: fix verification of device context Shachar Beiser
2017-07-26 9:06 ` Adrien Mazarguil
2017-07-26 9:21 ` Shachar Beiser
2017-07-26 12:55 ` Gaëtan Rivet
2017-07-26 13:30 ` [PATCH 0/6] fix ethdev device detach Gaetan Rivet
2017-07-26 13:30 ` [PATCH 1/6] ethdev: fix device state on detach Gaetan Rivet
2017-07-26 13:30 ` [PATCH 3/6] net/mlx4: advertize the detach capability Gaetan Rivet
2017-07-26 13:30 ` [PATCH 4/6] net/mlx5: " Gaetan Rivet
2017-07-26 13:30 ` [PATCH 5/6] app/testpmd: let the user know device detach failed Gaetan Rivet
2017-07-26 13:30 ` [PATCH 6/6] doc: announce ethdev API change for detach flag Gaetan Rivet
2017-07-26 13:35 ` Gaetan Rivet [this message]
2017-07-26 13:35 ` [PATCH v2 1/6] ethdev: fix device state on detach Gaetan Rivet
2017-07-26 13:35 ` [PATCH v2 2/6] ethdev: properly check detach capability Gaetan Rivet
2017-07-26 13:35 ` [PATCH v2 3/6] net/mlx4: advertize the " Gaetan Rivet
2017-07-26 13:35 ` [PATCH v2 4/6] net/mlx5: " Gaetan Rivet
2017-07-26 13:35 ` [PATCH v2 5/6] app/testpmd: let the user know device detach failed Gaetan Rivet
2017-07-26 13:35 ` [PATCH v2 6/6] doc: announce ethdev API change for detach flag Gaetan Rivet
2017-07-28 15:54 ` Mcnamara, John
2017-07-31 9:40 ` [PATCH v3] " Gaetan Rivet
2017-08-08 8:37 ` Thomas Monjalon
2017-07-30 7:33 ` [PATCH v2 0/6] fix ethdev device detach Shachar Beiser
2017-07-31 8:57 ` Adrien Mazarguil
2017-07-31 9:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1501076035.git.gaetan.rivet@6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=shacharbe@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.