From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatoly Burakov Subject: [PATCH 0/3] Coverity fixes for DPDK IPC Date: Tue, 17 Apr 2018 16:46:23 +0100 Message-ID: Cc: thomas@monjalon.net To: dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 437EEAAB3 for ; Tue, 17 Apr 2018 17:46:29 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patchset fixes a few Coverity issues introduced when various parts of DPDK IPC were added, and explains away other reported issues. Coverity issues fixed: - 272595 - return without mutex unlock - 272609 - fd leak Coverity issues intentionally not fixed: - 260407 - strcpy into fixed size buffer - Both src and dst strings are fixed size, so this is false positive - Hopefully will be silenced by replacing strcpy with strlcpy - 272565 - strcpy into fixed size buffer - Same as above - 272582 - strcpy into fixed size buffer - Same as above - 268321 - tainted string - Not an issue, we handle errors correctly - 272593 - tainted string - Same as above - 272604 - tainted string - Same as above - 260410 - not checking return value of rte_thread_setname - We intentionally don't care if it fails - 272583 - return without mutex unlock - Independently discovered and fixed [1] [1] http://dpdk.org/dev/patchwork/patch/38042/ Anatoly Burakov (3): ipc: use strlcpy where applicable ipc: fix return without mutex unlock ipc: fix resource leak lib/librte_eal/common/eal_common_proc.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) -- 2.7.4