All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net
Subject: [PATCH v3 0/9] Coverity fixes for EAL memory
Date: Wed, 25 Apr 2018 10:56:38 +0100	[thread overview]
Message-ID: <cover.1524650130.git.anatoly.burakov@intel.com> (raw)
In-Reply-To: <cover.1523977588.git.anatoly.burakov@intel.com>

This patchset fixes a host of coverity issues in memory subsystem
introduced with recent DPDK memory hotplug patchset.

Coverity issues fixed:
- 272601 - leaking fd
- 272560 - double close fd
- 272568 - leaking fd
- 272570 - leaking fd
- 272589 - dereference before null check
- 272602 - freeing wrong pointer
- 272608 - expression does nothing
- 272584 - use after free

Coverity issues not fixed:
- 272577 - negative return not handled
- 272578 - negative return not handled
  - Proper usage of API guarantees no negative returns

Additionally, also replace all instances of snprintf with strlcpy.

v3:
- Drop fixes for 272577 and 272578 and mark them as false positives

v2:
- Rebase on top of latest master

Anatoly Burakov (9):
  mem: use strlcpy instead of snprintf
  mem: fix resource leak
  mem: fix potential double close
  mem: fix potential resource leak
  mem: fix potential resource leak
  mem: fix comparing pointer to value
  mem: fix potential bad unmap
  mem: fix statement having no effect
  mem: fix possible use-after-free

 lib/librte_eal/common/eal_common_memalloc.c |  5 +++--
 lib/librte_eal/common/eal_common_memory.c   |  6 +++---
 lib/librte_eal/linuxapp/eal/eal_memalloc.c  | 22 ++++++++++++++++------
 lib/librte_eal/linuxapp/eal/eal_memory.c    |  1 +
 4 files changed, 23 insertions(+), 11 deletions(-)

-- 
2.7.4

  parent reply	other threads:[~2018-04-25  9:56 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17 15:50 [PATCH 00/10] Coverity fixes for EAL memory Anatoly Burakov
2018-04-17 15:50 ` [PATCH 01/10] mem: use strlcpy instead of snprintf Anatoly Burakov
2018-04-17 15:50 ` [PATCH 02/10] mem: fix resource leak Anatoly Burakov
2018-04-17 15:50 ` [PATCH 03/10] mem: fix potential double close Anatoly Burakov
2018-04-17 15:50 ` [PATCH 04/10] mem: fix potential resource leak Anatoly Burakov
2018-04-17 15:50 ` [PATCH 05/10] " Anatoly Burakov
2018-04-17 15:50 ` [PATCH 06/10] mem: fix comparing pointer to value Anatoly Burakov
2018-04-17 15:50 ` [PATCH 07/10] mem: fix potential bad unmap Anatoly Burakov
2018-04-17 15:50 ` [PATCH 08/10] mem: fix statement having no effect Anatoly Burakov
2018-04-17 15:50 ` [PATCH 09/10] mem: fix negative return value Anatoly Burakov
2018-04-17 15:50 ` [PATCH 10/10] mem: fix possible use-after-free Anatoly Burakov
2018-04-17 15:56 ` [PATCH 00/10] Coverity fixes for EAL memory Thomas Monjalon
2018-04-17 16:09   ` Burakov, Anatoly
2018-04-17 18:59     ` Thomas Monjalon
2018-04-18 10:37 ` [PATCH v2 " Anatoly Burakov
2018-04-18 10:37   ` [PATCH v2 01/10] mem: use strlcpy instead of snprintf Anatoly Burakov
2018-04-18 10:37   ` [PATCH v2 02/10] mem: fix resource leak Anatoly Burakov
2018-04-18 10:37   ` [PATCH v2 03/10] mem: fix potential double close Anatoly Burakov
2018-04-18 10:37   ` [PATCH v2 04/10] mem: fix potential resource leak Anatoly Burakov
2018-04-18 10:37   ` [PATCH v2 05/10] " Anatoly Burakov
2018-04-18 10:37   ` [PATCH v2 06/10] mem: fix comparing pointer to value Anatoly Burakov
2018-04-18 10:37   ` [PATCH v2 07/10] mem: fix potential bad unmap Anatoly Burakov
2018-04-18 10:37   ` [PATCH v2 08/10] mem: fix statement having no effect Anatoly Burakov
2018-04-18 10:37   ` [PATCH v2 09/10] mem: fix negative return value Anatoly Burakov
2018-04-18 10:37   ` [PATCH v2 10/10] mem: fix possible use-after-free Anatoly Burakov
2018-04-25  9:56 ` Anatoly Burakov [this message]
2018-04-25  9:56   ` [PATCH v3 1/9] mem: use strlcpy instead of snprintf Anatoly Burakov
2018-04-27 15:08     ` Bruce Richardson
2018-04-25  9:56   ` [PATCH v3 2/9] mem: fix resource leak Anatoly Burakov
2018-04-27 15:13     ` Bruce Richardson
2018-04-25  9:56   ` [PATCH v3 3/9] mem: fix potential double close Anatoly Burakov
2018-04-27 15:15     ` Bruce Richardson
2018-04-27 16:56       ` Burakov, Anatoly
2018-04-25  9:56   ` [PATCH v3 4/9] mem: fix potential resource leak Anatoly Burakov
2018-04-27 15:18     ` Bruce Richardson
2018-04-27 15:28       ` Burakov, Anatoly
2018-04-27 15:39       ` Burakov, Anatoly
2018-04-27 15:48         ` Bruce Richardson
2018-04-25  9:56   ` [PATCH v3 5/9] " Anatoly Burakov
2018-04-27 15:21     ` Bruce Richardson
2018-04-27 15:49       ` Burakov, Anatoly
2018-04-27 15:52         ` Bruce Richardson
2018-04-27 15:55       ` Burakov, Anatoly
2018-04-27 16:27         ` Bruce Richardson
2018-04-27 16:42           ` Burakov, Anatoly
2018-04-25  9:56   ` [PATCH v3 6/9] mem: fix comparing pointer to value Anatoly Burakov
2018-04-27 15:22     ` Bruce Richardson
2018-04-25  9:56   ` [PATCH v3 7/9] mem: fix potential bad unmap Anatoly Burakov
2018-04-27 15:37     ` Bruce Richardson
2018-04-25  9:56   ` [PATCH v3 8/9] mem: fix statement having no effect Anatoly Burakov
2018-04-27 15:39     ` Bruce Richardson
2018-04-25  9:56   ` [PATCH v3 9/9] mem: fix possible use-after-free Anatoly Burakov
2018-04-27 15:45     ` Bruce Richardson
2018-04-27 17:07   ` [PATCH v4 0/9] Coverity fixes for EAL memory Anatoly Burakov
2018-04-27 17:07     ` [PATCH v4 1/9] mem: use strlcpy instead of snprintf Anatoly Burakov
2018-04-27 17:07     ` [PATCH v4 2/9] mem: fix resource leak Anatoly Burakov
2018-04-27 17:07     ` [PATCH v4 3/9] mem: fix potential double close Anatoly Burakov
2018-04-30  9:00       ` Bruce Richardson
2018-04-27 17:07     ` [PATCH v4 4/9] mem: fix potential resource leak Anatoly Burakov
2018-04-27 17:07     ` [PATCH v4 5/9] " Anatoly Burakov
2018-04-27 17:07     ` [PATCH v4 6/9] mem: fix comparing pointer to value Anatoly Burakov
2018-04-27 17:07     ` [PATCH v4 7/9] mem: fix potential bad unmap Anatoly Burakov
2018-04-27 17:07     ` [PATCH v4 8/9] mem: fix statement having no effect Anatoly Burakov
2018-04-27 17:07     ` [PATCH v4 9/9] mem: fix possible use-after-free Anatoly Burakov
2018-04-27 21:25     ` [PATCH v4 0/9] Coverity fixes for EAL memory Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1524650130.git.anatoly.burakov@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.