From: Davide Caratti <dcaratti@redhat.com>
To: Jiri Pirko <jiri@resnulli.us>, Amir Vadai <amir@vadai.me>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH net 0/2] net/sched: fix NULL dereference in 'goto chain' control action
Date: Fri, 6 Jul 2018 21:01:04 +0200 [thread overview]
Message-ID: <cover.1530903047.git.dcaratti@redhat.com> (raw)
in a couple of TC actions (i.e. csum and tunnel_key), the control action
is stored together with the action-specific configuration data.
This avoids a race condition (see [1]), but it causes a crash when 'goto
chain' is used with the above actions. Since this race condition is
tolerated on the other TC actions (it's present even on actions where the
spinlock is still used), storing the control action in the common area
should be acceptable for tunnel_key and csum as well.
[1] https://www.spinics.net/lists/netdev/msg472047.html
Davide Caratti (2):
net/sched: act_csum: fix NULL dereference when 'goto chain' is used
net/sched: act_tunnel_key: fix NULL dereference when 'goto chain' is
used
include/net/tc_act/tc_csum.h | 1 -
include/net/tc_act/tc_tunnel_key.h | 1 -
net/sched/act_csum.c | 6 +++---
net/sched/act_tunnel_key.c | 6 +++---
4 files changed, 6 insertions(+), 8 deletions(-)
--
2.17.1
next reply other threads:[~2018-07-06 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 19:01 Davide Caratti [this message]
2018-07-06 19:01 ` [PATCH net 1/2] net/sched: act_csum: fix NULL dereference when 'goto chain' is used Davide Caratti
2018-07-06 19:01 ` [PATCH net 2/2] net/sched: act_tunnel_key: " Davide Caratti
2018-07-07 13:01 ` [PATCH net 0/2] net/sched: fix NULL dereference in 'goto chain' control action David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1530903047.git.dcaratti@redhat.com \
--to=dcaratti@redhat.com \
--cc=amir@vadai.me \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.