From: Paolo Abeni <pabeni@redhat.com>
To: netdev@vger.kernel.org
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Daniel Borkmann <daniel@iogearbox.net>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Eyal Birger <eyal.birger@gmail.com>
Subject: [PATCH net-next 0/4] TC: refactor act_mirred packets re-injection
Date: Thu, 19 Jul 2018 15:02:25 +0200 [thread overview]
Message-ID: <cover.1531941678.git.pabeni@redhat.com> (raw)
This series is aimed at improving the act_mirred redirect performances.
Such action is used by OVS to represent TC S/W flows, and it's current largest
bottle-neck is the need for a skb_clone() for each packet.
The first 2 patches introduce some cleanup and safeguards to allow extending
tca_result: we will use it to store RCU protected redirect information.
Then a new tca_action value is introduced: TC_ACT_MIRRED, similar to
TC_ACT_REDIRECT, but preserving the mirred semantic. The last patch exploits
the introduced infrastructure in the act_mirred action, to avoid a skb_clone,
when possible.
Overall this the above gives a ~10% performance improvement in forwarding tput,
when using the TC S/W datapath.
v1 -> v2:
- preserve the rcu lock in act_bpf
- add and use a new action value to reinject the packets, preserving the mirred
semantic
Paolo Abeni (4):
tc/act: user space can't use TC_ACT_REDIRECT directly
tc/act: remove unneeded RCU lock in action callback
net/tc: introduce TC_ACT_MIRRED.
act_mirred: use ACT_MIRRED when possible
include/net/act_api.h | 2 +-
include/net/sch_generic.h | 21 +++++++++++++++++++++
include/uapi/linux/pkt_cls.h | 2 ++
net/core/dev.c | 4 ++++
net/sched/act_api.c | 7 +++++++
net/sched/act_csum.c | 12 +++---------
net/sched/act_ife.c | 5 +----
net/sched/act_mirred.c | 35 +++++++++++++++++++++++------------
net/sched/act_sample.c | 4 +---
net/sched/act_skbedit.c | 10 +++-------
net/sched/act_skbmod.c | 21 +++++++++------------
net/sched/act_tunnel_key.c | 6 +-----
net/sched/act_vlan.c | 19 +++++++------------
13 files changed, 83 insertions(+), 65 deletions(-)
--
2.17.1
next reply other threads:[~2018-07-19 13:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 13:02 Paolo Abeni [this message]
2018-07-19 13:02 ` [PATCH net-next 1/4] tc/act: user space can't use TC_ACT_REDIRECT directly Paolo Abeni
2018-07-19 13:02 ` [PATCH net-next 2/4] tc/act: remove unneeded RCU lock in action callback Paolo Abeni
2018-07-19 13:02 ` [PATCH net-next 3/4] net/tc: introduce TC_ACT_MIRRED Paolo Abeni
2018-07-19 18:07 ` Cong Wang
2018-07-20 9:54 ` Paolo Abeni
2018-07-23 21:12 ` Cong Wang
2018-07-24 6:48 ` Paolo Abeni
2018-07-19 18:56 ` Jiri Pirko
2018-07-19 13:02 ` [PATCH net-next 4/4] act_mirred: use ACT_MIRRED when possible Paolo Abeni
2018-07-21 23:29 ` David Miller
2018-07-22 14:32 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1531941678.git.pabeni@redhat.com \
--to=pabeni@redhat.com \
--cc=daniel@iogearbox.net \
--cc=eyal.birger@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.