From: Omar Sandoval <osandov@osandov.com>
To: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>
Cc: David Sterba <dsterba@suse.com>, kernel-team@fb.com
Subject: [RFC PATCH v2 0/6] Btrfs: stop abusing current->journal_info for direct I/O
Date: Mon, 27 Aug 2018 17:03:13 -0700 [thread overview]
Message-ID: <cover.1535414064.git.osandov@fb.com> (raw)
From: Omar Sandoval <osandov@fb.com>
Hi,
This is a different approach from v1 [1] of this series to stop abusing
current->journal_info in Btrfs. This approach unifies everything to use
iocb->private instead of map_bh->b_private. Patches 1 and 5 pass the
iocb to a couple of callbacks which need it. Patches 2 and 3 migrates
the users of b_private to use iocb->private, and patch 4 gets rid of the
b_private handling in the direct I/O code. Patch 6 cleans up Btrfs.
I'm not convinced that this is cleaner that my first approach, but it at
least avoids growing the argument list to do_blockdev_direct_IO(), which
was Al's complaint of v1.
Thanks!
1: https://www.spinics.net/lists/linux-btrfs/msg77859.html
Omar Sandoval (6):
fs: pass iocb to direct I/O get_block()
ext4: use iocb->private instead of bh->b_private
ocfs2: use iocb->private instead of bh->b_private
fs: stop propagating bh->b_private for direct I/O
fs: pass iocb to direct I/O submit_io()
Btrfs: stop abusing current->journal_info in btrfs_direct_IO()
fs/affs/file.c | 9 ++++++-
fs/btrfs/inode.c | 36 +++++++------------------
fs/direct-io.c | 23 +++++++---------
fs/ext2/inode.c | 9 ++++++-
fs/ext4/ext4.h | 2 --
fs/ext4/inode.c | 40 ++++++++++++++++------------
fs/f2fs/data.c | 5 ++--
fs/fat/inode.c | 9 ++++++-
fs/gfs2/aops.c | 5 ++--
fs/hfs/inode.c | 9 ++++++-
fs/hfsplus/inode.c | 9 ++++++-
fs/jfs/inode.c | 9 ++++++-
fs/nilfs2/inode.c | 9 ++++++-
fs/ocfs2/aops.c | 39 ++++++++++++++-------------
fs/ocfs2/aops.h | 64 ++++++++++++++++++++++++++++++---------------
fs/reiserfs/inode.c | 4 +--
fs/udf/inode.c | 9 ++++++-
include/linux/fs.h | 17 ++++++------
18 files changed, 187 insertions(+), 120 deletions(-)
--
2.18.0
next reply other threads:[~2018-08-28 3:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 0:03 Omar Sandoval [this message]
2018-08-28 0:03 ` [RFC PATCH v2 1/6] fs: pass iocb to direct I/O get_block() Omar Sandoval
2018-08-28 0:03 ` [RFC PATCH v2 2/6] ext4: use iocb->private instead of bh->b_private Omar Sandoval
2018-08-28 0:03 ` [RFC PATCH v2 3/6] ocfs2: " Omar Sandoval
2018-08-28 0:03 ` [RFC PATCH v2 4/6] fs: stop propagating bh->b_private for direct I/O Omar Sandoval
2018-08-28 0:03 ` [RFC PATCH v2 5/6] fs: pass iocb to direct I/O submit_io() Omar Sandoval
2018-08-28 0:03 ` [RFC PATCH v2 6/6] Btrfs: stop abusing current->journal_info in btrfs_direct_IO() Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1535414064.git.osandov@fb.com \
--to=osandov@osandov.com \
--cc=dsterba@suse.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.