From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: Alberto Garcia <berto@igalia.com>,
qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 0/3] iothread-related fixes for virtio-scsi
Date: Tue, 22 Jan 2019 17:53:20 +0200 [thread overview]
Message-ID: <cover.1548171741.git.berto@igalia.com> (raw)
Hi,
here are three patches with iothread-related fixes for virtio-scsi,
with their test cases.
This series fixes the following bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1656276
https://bugzilla.redhat.com/show_bug.cgi?id=1662508
I also wanted to do prepare a similar one for virtio-blk but I'm
unsure about how to proceed, because I'm unable to detect during
realize() that the blockdev is using a different iothread. This
crashes QEMU:
{ "execute": "qmp_capabilities" }
{ "execute": "blockdev-add", "arguments": {"driver": "null-co", "node-name": "hd0", "read-only": true}}
{ "execute": "object-add", "arguments": {"qom-type": "iothread", "id": "iothread0"}}
{ "execute": "object-add", "arguments": {"qom-type": "iothread", "id": "iothread1"}}
{ "execute": "device_add", "arguments": {"id": "virtio-blk0", "driver": "virtio-blk", "iothread": "iothread0", "drive": "hd0"}}
{ "execute": "system_reset"}
(wait for the events)
{ "execute": "device_add", "arguments": {"id": "virtio-blk1", "driver": "virtio-blk", "iothread": "iothread1", "drive": "hd0"}}
Regards,
Berto
Alberto Garcia (3):
virtio-scsi: Move BlockBackend back to the main AioContext on unplug
scsi-disk: Acquire the AioContext in scsi_*_realize()
virtio-scsi: Forbid devices with different iothreads sharing a
blockdev
hw/scsi/scsi-disk.c | 23 ++++++--
hw/scsi/virtio-scsi.c | 13 +++++
tests/qemu-iotests/240 | 129 +++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/240.out | 54 +++++++++++++++++++
tests/qemu-iotests/group | 1 +
5 files changed, 217 insertions(+), 3 deletions(-)
create mode 100755 tests/qemu-iotests/240
create mode 100644 tests/qemu-iotests/240.out
--
2.11.0
next reply other threads:[~2019-01-22 19:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:53 Alberto Garcia [this message]
2019-01-22 15:53 ` [Qemu-devel] [PATCH 1/3] virtio-scsi: Move BlockBackend back to the main AioContext on unplug Alberto Garcia
2019-01-22 15:53 ` [Qemu-devel] [PATCH 2/3] scsi-disk: Acquire the AioContext in scsi_*_realize() Alberto Garcia
2019-01-22 15:53 ` [Qemu-devel] [PATCH 3/3] virtio-scsi: Forbid devices with different iothreads sharing a blockdev Alberto Garcia
2019-01-23 9:46 ` Paolo Bonzini
2019-01-23 15:09 ` Alberto Garcia
2019-01-23 15:47 ` Paolo Bonzini
2019-01-23 16:16 ` Alberto Garcia
2019-01-24 9:12 ` Kevin Wolf
2019-01-28 14:42 ` Alberto Garcia
2019-01-28 14:57 ` Kevin Wolf
2019-01-28 15:46 ` Alberto Garcia
2019-01-28 16:01 ` Kevin Wolf
2019-01-28 16:15 ` Alberto Garcia
2019-01-28 16:30 ` Kevin Wolf
2019-01-28 15:31 ` [Qemu-devel] [PATCH 0/3] iothread-related fixes for virtio-scsi Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1548171741.git.berto@igalia.com \
--to=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.