From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A228C43381 for ; Thu, 28 Mar 2019 15:53:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BB0820823 for ; Thu, 28 Mar 2019 15:53:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726344AbfC1Pxd (ORCPT ); Thu, 28 Mar 2019 11:53:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46810 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726173AbfC1Pxc (ORCPT ); Thu, 28 Mar 2019 11:53:32 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7533630018F8; Thu, 28 Mar 2019 15:53:32 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.32.181.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE9F95C582; Thu, 28 Mar 2019 15:53:29 +0000 (UTC) From: Paolo Abeni To: netdev@vger.kernel.org Cc: "David S. Miller" , Jamal Hadi Salim , Cong Wang , Jiri Pirko , John Fastabend Subject: [PATCH net 0/2] net: sched: fix stats accounting for child NOLOCK qdiscs Date: Thu, 28 Mar 2019 16:53:11 +0100 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 28 Mar 2019 15:53:32 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently, stats accounting for NOLOCK qdisc enslaved to classful (lock) qdiscs is buggy. Per CPU values are ignored in most places, as a result, stats dump in the above scenario always report 0 length backlog and parent backlog len is not updated correctly on NOLOCK qdisc removal. The first patch address stats dumping, and the second one child qdisc removal. I'm targeting the net tree as this is a bugfix, but it could be moved to net-next due to the relatively large diffstat. Paolo Abeni (2): net: sched: introduce and use qstats read helpers net: sched: introduce and use qdisc tree flush/purge helpers include/net/sch_generic.h | 44 ++++++++++++++++++++++++++++++++------- net/sched/sch_cbq.c | 10 ++++----- net/sched/sch_drr.c | 16 ++++---------- net/sched/sch_hfsc.c | 19 +++++------------ net/sched/sch_htb.c | 22 ++++++-------------- net/sched/sch_mq.c | 2 +- net/sched/sch_mqprio.c | 3 +-- net/sched/sch_multiq.c | 10 ++++----- net/sched/sch_prio.c | 10 +++------ net/sched/sch_qfq.c | 14 ++----------- net/sched/sch_red.c | 3 +-- net/sched/sch_sfb.c | 3 +-- net/sched/sch_taprio.c | 2 +- net/sched/sch_tbf.c | 3 +-- 14 files changed, 71 insertions(+), 90 deletions(-) -- 2.20.1