From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:45598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLtkb-0007N2-RO for qemu-devel@nongnu.org; Wed, 01 May 2019 14:14:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLtka-0002bN-0P for qemu-devel@nongnu.org; Wed, 01 May 2019 14:14:37 -0400 From: Alberto Garcia Date: Wed, 1 May 2019 21:13:54 +0300 Message-Id: Subject: [Qemu-devel] [PATCH v2 0/5] Remove bdrv_read() and bdrv_write() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alberto Garcia , qemu-block@nongnu.org, Max Reitz , Kevin Wolf , Eric Blake Hi, this API only had a few users left so it can be easily removed. Regards, Berto v2: - Patch 2: Add QEMU_BUILD_BUG_ON(sizeof(VdiHeader) != 512) [Kevin] Correct size parameter in bdrv_pwrite() call [Kevin] Return 0 on success, never a positive number [Kevin] - Patch 3: Check that the return values of bdrv_pread()/bdrv_pwrite() are strictly < 0 for errors, not simply != 0 [Kevin] - Patch 4: Reuse the documenation of bdrv_write() for bdrv_pwrite() v1: https://lists.gnu.org/archive/html/qemu-block/2019-04/msg00832.html Output of git backport-diff against v1: Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively 001/5:[----] [--] 'qcow2: Replace bdrv_write() with bdrv_pwrite()' 002/5:[0006] [FC] 'vdi: Replace bdrv_{read,write}() with bdrv_{pread,pwrite}()' 003/5:[0004] [FC] 'vvfat: Replace bdrv_{read,write}() with bdrv_{pread,pwrite}()' 004/5:[0007] [FC] 'block: Remove bdrv_read() and bdrv_write()' 005/5:[----] [--] 'qcow2: Remove BDRVQcow2State.cluster_sectors' Alberto Garcia (5): qcow2: Replace bdrv_write() with bdrv_pwrite() vdi: Replace bdrv_{read,write}() with bdrv_{pread,pwrite}() vvfat: Replace bdrv_{read,write}() with bdrv_{pread,pwrite}() block: Remove bdrv_read() and bdrv_write() qcow2: Remove BDRVQcow2State.cluster_sectors block/io.c | 43 +++++++------------------------------------ block/qcow2-refcount.c | 4 ++-- block/qcow2.c | 1 - block/qcow2.h | 1 - block/vdi.c | 15 +++++++++------ block/vvfat.c | 12 +++++++----- include/block/block.h | 4 ---- 7 files changed, 25 insertions(+), 55 deletions(-) -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FF0BC43219 for ; Wed, 1 May 2019 18:19:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE05C20675 for ; Wed, 1 May 2019 18:19:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="gSOVxN6b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE05C20675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:38050 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLtpJ-0001yL-2r for qemu-devel@archiver.kernel.org; Wed, 01 May 2019 14:19:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLtkb-0007N2-RO for qemu-devel@nongnu.org; Wed, 01 May 2019 14:14:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLtka-0002bN-0P for qemu-devel@nongnu.org; Wed, 01 May 2019 14:14:37 -0400 Received: from fanzine.igalia.com ([91.117.99.155]:38855) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLtkZ-0002RF-F0; Wed, 01 May 2019 14:14:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Message-Id:Date:Subject:Cc:To:From; bh=VpAjM62bTp4qH7PxA2I0vH56bsFYsGYttjkSE3mbP8M=; b=gSOVxN6blVerRfnd1BfkZpO1rEe2IvxQIbBUX13K8RX/pu84aL2JJTrrFi3FT6O9bG/UFbzmA7haqtrBzxugSuS9HhqMEg44HthXMWwjmhsHCAU9SZ6D5oc/RuPco+o3PYiGHbjHwamXyofpc9YsVw5KMeC3BRwR/xkIUJuM79jNKXpkkg7dytuuB7IhvjxrpBfXBnvJPG4Q6JCAvtR3VJweuzIYu+gGJcNL3/KsO4sMaYSPpFxYQVpxMgvA6Wm3YGZeDtCIkcb996M50QXMapLfEWZ9/pAbETO3H7K4ePVgauT4Awv07Udk0SZCIza1TXV8ToQic4xipxDYj2tDbw==; Received: from 87-92-6-174.bb.dnainternet.fi ([87.92.6.174] helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1hLtkH-0002E9-7Q; Wed, 01 May 2019 20:14:17 +0200 Received: from berto by perseus.local with local (Exim 4.89) (envelope-from ) id 1hLtk2-0002yH-HC; Wed, 01 May 2019 21:14:02 +0300 From: Alberto Garcia To: qemu-devel@nongnu.org Date: Wed, 1 May 2019 21:13:54 +0300 Message-Id: X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: [Qemu-devel] [PATCH v2 0/5] Remove bdrv_read() and bdrv_write() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190501181354.U8l7H5N1v49dk1n7Vkpt6__fV9PDjvilST1trfcJ52I@z> Hi, this API only had a few users left so it can be easily removed. Regards, Berto v2: - Patch 2: Add QEMU_BUILD_BUG_ON(sizeof(VdiHeader) != 512) [Kevin] Correct size parameter in bdrv_pwrite() call [Kevin] Return 0 on success, never a positive number [Kevin] - Patch 3: Check that the return values of bdrv_pread()/bdrv_pwrite() are strictly < 0 for errors, not simply != 0 [Kevin] - Patch 4: Reuse the documenation of bdrv_write() for bdrv_pwrite() v1: https://lists.gnu.org/archive/html/qemu-block/2019-04/msg00832.html Output of git backport-diff against v1: Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively 001/5:[----] [--] 'qcow2: Replace bdrv_write() with bdrv_pwrite()' 002/5:[0006] [FC] 'vdi: Replace bdrv_{read,write}() with bdrv_{pread,pwrite}()' 003/5:[0004] [FC] 'vvfat: Replace bdrv_{read,write}() with bdrv_{pread,pwrite}()' 004/5:[0007] [FC] 'block: Remove bdrv_read() and bdrv_write()' 005/5:[----] [--] 'qcow2: Remove BDRVQcow2State.cluster_sectors' Alberto Garcia (5): qcow2: Replace bdrv_write() with bdrv_pwrite() vdi: Replace bdrv_{read,write}() with bdrv_{pread,pwrite}() vvfat: Replace bdrv_{read,write}() with bdrv_{pread,pwrite}() block: Remove bdrv_read() and bdrv_write() qcow2: Remove BDRVQcow2State.cluster_sectors block/io.c | 43 +++++++------------------------------------ block/qcow2-refcount.c | 4 ++-- block/qcow2.c | 1 - block/qcow2.h | 1 - block/vdi.c | 15 +++++++++------ block/vvfat.c | 12 +++++++----- include/block/block.h | 4 ---- 7 files changed, 25 insertions(+), 55 deletions(-) -- 2.11.0