From: Shobhit Kukreti <shobhitkukreti@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bastien Nocera <hadess@hadess.net>,
Hans de Goede <hdegoede@redhat.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Joe Perches <joe@perches.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Shobhit Kukreti <shobhitkukreti@gmail.com>
Subject: [PATCH v4 0/3] Resolve if/else brace-style errors
Date: Tue, 18 Jun 2019 17:37:31 -0700 [thread overview]
Message-ID: <cover.1560903975.git.shobhitkukreti@gmail.com> (raw)
In-Reply-To: <20190618070019.GA20601@kroah.com>
This patchset fixes the following errors reported by checkpatch in the
staging/rtl8723bs driver.
Patch[1/3]: Fix check patch error "that open brace { should be on the
previous line"
Patch[2/3]: Fix the error else should follow close brace '}'
Patch[3/3]: Fix Indentation Error
The patch should be applied in the sequence of 1-3.
Each patch performs one clean up operation.
version 4 changes:
- Moved comments to a new line
- Removed an extra blank line
version 3 changes:
- Converted the patch to a patchset
- Resolve checkpatch errors:
else should follow close brace '}'
Fixed Indentation Error to use tabs
- Compiles and builds, untested on real hardware.
version 2 changes:
- Removed Trailing whitespace introduced in the previous patch
- Moved comments to a new line in the else statement
Shobhit Kukreti (3):
staging: rtl8723bs: Resolve checkpatch error "that open brace { should
be on the previous line" in the rtl8723 driver
staging: rtl8723bs: Resolve the checkpatch error: else should follow
close brace '}'
staging: rtl8723bs: Fix Indentation Error: code indent should use tabs
where possible
drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 18 ++---
drivers/staging/rtl8723bs/os_dep/recv_linux.c | 89 ++++++++---------------
drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 6 +-
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 54 ++++++--------
drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c | 24 ++----
5 files changed, 69 insertions(+), 122 deletions(-)
--
2.7.4
next prev parent reply other threads:[~2019-06-19 0:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 2:12 [PATCH] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723bs driver Shobhit Kukreti
2019-06-15 18:53 ` Greg Kroah-Hartman
2019-06-15 21:29 ` [PATCH v2] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver Shobhit Kukreti
2019-06-16 8:13 ` Joe Perches
2019-06-16 13:11 ` Shobhit Kukreti
2019-06-16 16:19 ` [PATCH v3 0/3] Resolve checkpatch if/else brace style errors Shobhit Kukreti
2019-06-16 16:19 ` [PATCH v3 1/3] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver Shobhit Kukreti
2019-06-18 7:00 ` Greg Kroah-Hartman
2019-06-19 0:37 ` Shobhit Kukreti [this message]
2019-06-19 0:37 ` [PATCH v4 " Shobhit Kukreti
2019-06-19 0:37 ` [PATCH v4 2/3] staging: rtl8723bs: Resolve the checkpatch error: else should follow close brace '}' Shobhit Kukreti
2019-06-19 0:37 ` [PATCH v4 3/3] staging: rtl8723bs: Fix Indentation Error: code indent should use tabs where possible Shobhit Kukreti
2019-06-16 16:19 ` [PATCH v3 2/3] staging: rtl8723bs: Resolve the checkpatch error: else should follow close brace '}' Shobhit Kukreti
2019-06-16 16:19 ` [PATCH v3 3/3] staging: rtl8723bs: Fix Indentation Error: code indent should use tabs where possible Shobhit Kukreti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1560903975.git.shobhitkukreti@gmail.com \
--to=shobhitkukreti@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.