From: Andrea Claudi <aclaudi@redhat.com>
To: netdev@vger.kernel.org
Cc: stephen@networkplumber.org, dsahern@kernel.org
Subject: [PATCH iproute2 v2 0/3] do not set IPv6-only options on IPv4 addresses
Date: Tue, 25 Jun 2019 12:29:54 +0200 [thread overview]
Message-ID: <cover.1561457597.git.aclaudi@redhat.com> (raw)
'home', 'nodad' and 'mngtmpaddr' options are IPv6-only, but
it is possible to set them on IPv4 addresses, too. This should
not be possible.
Fix this adding a check on the protocol family before setting
the flags, and print warning messages on error to not break
existing scripted setups.
Andrea Claudi (3):
ip address: do not set nodad option for IPv4 addresses
ip address: do not set home option for IPv4 addresses
ip address: do not set mngtmpaddr option for IPv4 addresses
ip/ipaddress.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
--
2.20.1
next reply other threads:[~2019-06-25 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 10:29 Andrea Claudi [this message]
2019-06-25 10:29 ` [PATCH iproute2 v2 1/3] ip address: do not set nodad option for IPv4 addresses Andrea Claudi
2019-06-25 10:29 ` [PATCH iproute2 v2 2/3] ip address: do not set home " Andrea Claudi
2019-06-25 10:29 ` [PATCH iproute2 v2 3/3] ip address: do not set mngtmpaddr " Andrea Claudi
2019-06-28 22:20 ` [PATCH iproute2 v2 0/3] do not set IPv6-only options on " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1561457597.git.aclaudi@redhat.com \
--to=aclaudi@redhat.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.