From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Siqueira Subject: [PATCH V3 0/5] drm/vkms: Introduces writeback support Date: Tue, 25 Jun 2019 22:35:30 -0300 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by gabe.freedesktop.org (Postfix) with ESMTPS id A419A6E17F for ; Wed, 26 Jun 2019 01:35:38 +0000 (UTC) Received: by mail-qt1-x842.google.com with SMTP id j19so620215qtr.12 for ; Tue, 25 Jun 2019 18:35:38 -0700 (PDT) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Brian Starkey , Liviu Dudau , Daniel Vetter , Haneen Mohammed , Simon Ser Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org VGhpcyBpcyB0aGUgVjMgdmVyc2lvbiBvZiBhIHNlcmllcyB0aGF0IGludHJvZHVjZXMgdGhlIHdy aXRlYmFjayBzdXBwb3J0CnRvIHZrbXMuIEFzIGEgcmVzdWx0IG9mIHRoZSBwcmV2aW91cyByZXZp ZXcsIHRoaXMgcGF0Y2hzZXQgY2FuIGJlIHNlZW4KaW4gdGhyZWUgcGFydHM6IG1ha2UgdmttcyBh YmxlIHRvIHN1cHBvcnQgbXVsdGlwbGUgY29ubmVjdG9yLCBwcmUtd29yawpmb3IgdmttcywgYW5k IHRoZSB2a21zIGltcGxlbWVudGF0aW9uLiBGb2xsb3dzIHRoZSBkZXRhaWxzOgoKKiBGaXJzdCBw YXJ0OiBUaGUgZmlyc3QgcGF0Y2ggb2YgdGhpcyBzZXJpZXMgaXMgYSBmaXggdGhhdCBlbmFibGVz IHZrbXMgdG8KYWNjZXB0IG5ldyBjb25uZWN0b3JzLCBzdWNoIGFzIHdyaXRlYmFjayBjb25uZWN0 b3IuCgoqIFNlY29uZCBwYXJ0OiBUaGUgc2Vjb25kIHBhcnQgb2YgdGhpcyBwYXRjaHNldCBzdGFy dHMgb24gcGF0Y2ggMDIgYW5kCmZpbmlzaCBvbiBwYXRjaCAwNDsgYmFzaWNhbGx5IGl0IGlzIGEg cHJlLXdvcmsgdGhhdCBhaW1zIHRvIG1ha2Ugdmttcwpjb21wb3NlciBvcGVyYXRpb25zIGEgbGl0 dGxlIGJpdCBtb3JlIGdlbmVyaWMuIFRoZXNlIHBhdGNoZXMgdXBkYXRlIHRoZQpDUkMgZmlsZXMg YW5kIGZ1bmN0aW9uIHRvIG1ha2UgaXQgd29yayBhcyBhIGNvbXBvc2VyOyBpdCBhbHNvCmNlbnRy YWxpemVzIHRoZSB2a21zIGZyYW1lYnVmZmVyIG9wZXJhdGlvbnMuIEFkZGl0aW9uYWxseSwgdGhl c2UgY2hhbmdlcwplbmFibGUgdGhlIGNvbXBvc2VyIHRvIHVzZSB0aGUgd3JpdGViYWNrIGZyYW1l YnVmZmVyIGluc3RlYWQgb2YgY3JlYXRpbmcKYSBjb3B5LgoKKiBUaGlyZCBwYXJ0OiBUaGUgZmlu YWwgcGF0Y2ggZW5hYmxlcyB0aGUgc3VwcG9ydCBmb3Igd3JpdGViYWNrIGluIHZrbXMuCgpXaXRo IHRoaXMgcGF0Y2hzZXQsIHZrbXMgY2FuIHN1Y2Nlc3NmdWxseSBwYXNzIGFsbCB0aGUga21zX3dy aXRlYmFjawp0ZXN0cyBmcm9tIElHVC4KCk5vdGU6IE1vc3Qgb2YgdGhlIGNoYW5nZXMgaW4gdGhl IFYzIHdhcyBzdWdnZXN0ZWQgYnkgRGFuaWVsIFZldHRlciBhcwpjYW4gYmUgc2VlbiBhdCB0aGUg bGluawpodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvMzExODQ0Lz9zZXJp ZXM9NjE3MzgmcmV2PTIKCk5vdGU6IFRoaXMgcGF0Y2hzZXQgZGVwZW5kcyBvbiBEYW5pZWwncyBy ZXdvcmsgb2YgQ1JDLCBzZWUgaXQgYXQKaHR0cHM6Ly9wYXRjaHdvcmsuZnJlZWRlc2t0b3Aub3Jn L3Nlcmllcy82MTczNy8KClJvZHJpZ28gU2lxdWVpcmEgKDUpOgogIGRybS92a21zOiBBdm9pZCBh c3NpZ25pbmcgMCBmb3IgcG9zc2libGVfY3J0YwogIGRybS92a21zOiBSZW5hbWUgdmttc19jcmMu YyBpbnRvIHZrbXNfY29tcG9zZXIuYwogIGRybS92a21zOiBEZWNvdXBsZSBjcmMgb3BlcmF0aW9u cyBmcm9tIGNvbXBvc2VyCiAgZHJtL3ZrbXM6IENvbXB1dGUgQ1JDIHdpdGhvdXQgY2hhbmdlIGlu cHV0IGRhdGEKICBkcm0vdmttczogQWRkIHN1cHBvcnQgZm9yIHdyaXRlYmFjawoKIGRyaXZlcnMv Z3B1L2RybS92a21zL01ha2VmaWxlICAgICAgICAgICAgICAgICB8ICAgOSArLQogLi4uL2RybS92 a21zL3t2a21zX2NyYy5jID0+IHZrbXNfY29tcG9zZXIuY30gIHwgMTc0ICsrKysrKysrKystLS0t LS0tLQogZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19jcnRjLmMgICAgICAgICAgICAgIHwgIDMw ICstLQogZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19kcnYuYyAgICAgICAgICAgICAgIHwgIDEw ICstCiBkcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2Rydi5oICAgICAgICAgICAgICAgfCAgNDAg KystLQogZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19vdXRwdXQuYyAgICAgICAgICAgIHwgIDE2 ICstCiBkcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX3BsYW5lLmMgICAgICAgICAgICAgfCAgNDAg KystLQogZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc193cml0ZWJhY2suYyAgICAgICAgIHwgMTQx ICsrKysrKysrKysrKysrCiA4IGZpbGVzIGNoYW5nZWQsIDMzMSBpbnNlcnRpb25zKCspLCAxMjkg ZGVsZXRpb25zKC0pCiByZW5hbWUgZHJpdmVycy9ncHUvZHJtL3ZrbXMve3ZrbXNfY3JjLmMgPT4g dmttc19jb21wb3Nlci5jfSAoNTElKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2Ry bS92a21zL3ZrbXNfd3JpdGViYWNrLmMKCi0tIAoyLjIxLjAKCgotLSAKUm9kcmlnbyBTaXF1ZWly YQpodHRwczovL3NpcXVlaXJhLnRlY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85114C48BD5 for ; Wed, 26 Jun 2019 01:35:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5AF9920883 for ; Wed, 26 Jun 2019 01:35:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xwx6E+6q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726760AbfFZBfl (ORCPT ); Tue, 25 Jun 2019 21:35:41 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:36396 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726750AbfFZBfi (ORCPT ); Tue, 25 Jun 2019 21:35:38 -0400 Received: by mail-qt1-f196.google.com with SMTP id p15so677419qtl.3 for ; Tue, 25 Jun 2019 18:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=0LRAWyCoMm6qSJUgjbP8auCw69o7m+ZLWJtl7bdpb+w=; b=Xwx6E+6qHDSLrgkTZG71QymmraL414RSn1b4jzWwNp/EQoGWChZXZCJ56w78XccijD 1E+OOkSvvoDBM1ir+vgbxhq1ETv2ASxey+QcHAk0RffvDLUpCIiMwzBDcvl8aTWrspM9 XsG2jdiayltXMWwNwSfszrKu3xxh8g/1rb9sEJ658YI+L7cYh87PrcXSNwTT8FBCTQh0 jSpvEBID8+gwLbrQXSN0vNMY/mZg9v5On4L2zmP6Dojuz9QVukaYW9nzhWxNcmYSyX9u KMQdnGm0JDSZRi1Aq5eGZ92rrFhJldEE9SjhMRf9na6KrjyWi0nw0bZg+A6eNEhBrwkL U09A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=0LRAWyCoMm6qSJUgjbP8auCw69o7m+ZLWJtl7bdpb+w=; b=o/e25BRC6FL1Obji4GYkqmfaPfpWktRWevuGwL/T49mw7FYp8B+gU+FDUN5meKXJUG PCvndAbW9wbYMEQ8paD8LTDFG/jtR1E/uhqJy9Dw+qUhtVl+gaFhkc0iEV6dhTZ/ii+a 5aosRHtNlcenClZnGJhiqptoeb/ENi/gqUBB54NvYPxMIp4tR5N4jcG+kIR2eKsdj7uP 1pD5MwUI67/Z0JnKuKKTnKGC2mD/FD22tVM9pfgspV8q5EtkFNc/WBH77XC3QFods7PU CofUH/kjSoa1sqqo7+7D4OTWzz+BoasWov4aFzfUd02CnHYc70lnsXUhIvp58Zp0M/6D oSrg== X-Gm-Message-State: APjAAAVdbhV1ywwsRxjR0fJo4w+v5aVc5An3fa3PBpDN473yt8iS1n8q cP2QEiXQYTAoMaaDrJLeMo0= X-Google-Smtp-Source: APXvYqxpXDznfBJclCVx7xXV0zdyxRpLK69Oa2CuicRUspRtYvD+5giOq5ZovANyg2wCLBplsqvwMQ== X-Received: by 2002:ac8:17a5:: with SMTP id o34mr1385680qtj.232.1561512937655; Tue, 25 Jun 2019 18:35:37 -0700 (PDT) Received: from smtp.gmail.com ([187.121.151.146]) by smtp.gmail.com with ESMTPSA id 123sm7343770qkh.113.2019.06.25.18.35.32 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 25 Jun 2019 18:35:36 -0700 (PDT) Date: Tue, 25 Jun 2019 22:35:30 -0300 From: Rodrigo Siqueira To: Brian Starkey , Liviu Dudau , Daniel Vetter , Haneen Mohammed , Simon Ser Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 0/5] drm/vkms: Introduces writeback support Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is the V3 version of a series that introduces the writeback support to vkms. As a result of the previous review, this patchset can be seen in three parts: make vkms able to support multiple connector, pre-work for vkms, and the vkms implementation. Follows the details: * First part: The first patch of this series is a fix that enables vkms to accept new connectors, such as writeback connector. * Second part: The second part of this patchset starts on patch 02 and finish on patch 04; basically it is a pre-work that aims to make vkms composer operations a little bit more generic. These patches update the CRC files and function to make it work as a composer; it also centralizes the vkms framebuffer operations. Additionally, these changes enable the composer to use the writeback framebuffer instead of creating a copy. * Third part: The final patch enables the support for writeback in vkms. With this patchset, vkms can successfully pass all the kms_writeback tests from IGT. Note: Most of the changes in the V3 was suggested by Daniel Vetter as can be seen at the link https://patchwork.freedesktop.org/patch/311844/?series=61738&rev=2 Note: This patchset depends on Daniel's rework of CRC, see it at https://patchwork.freedesktop.org/series/61737/ Rodrigo Siqueira (5): drm/vkms: Avoid assigning 0 for possible_crtc drm/vkms: Rename vkms_crc.c into vkms_composer.c drm/vkms: Decouple crc operations from composer drm/vkms: Compute CRC without change input data drm/vkms: Add support for writeback drivers/gpu/drm/vkms/Makefile | 9 +- .../drm/vkms/{vkms_crc.c => vkms_composer.c} | 174 ++++++++++-------- drivers/gpu/drm/vkms/vkms_crtc.c | 30 +-- drivers/gpu/drm/vkms/vkms_drv.c | 10 +- drivers/gpu/drm/vkms/vkms_drv.h | 40 ++-- drivers/gpu/drm/vkms/vkms_output.c | 16 +- drivers/gpu/drm/vkms/vkms_plane.c | 40 ++-- drivers/gpu/drm/vkms/vkms_writeback.c | 141 ++++++++++++++ 8 files changed, 331 insertions(+), 129 deletions(-) rename drivers/gpu/drm/vkms/{vkms_crc.c => vkms_composer.c} (51%) create mode 100644 drivers/gpu/drm/vkms/vkms_writeback.c -- 2.21.0 -- Rodrigo Siqueira https://siqueira.tech