All of lore.kernel.org
 help / color / mirror / Atom feed
From: Davide Caratti <dcaratti at redhat.com>
To: mptcp at lists.01.org
Subject: [MPTCP] [PATCH v2 0/2] mptcp: simplify crypto.c
Date: Tue, 23 Jul 2019 19:47:18 +0200	[thread overview]
Message-ID: <cover.1563903620.git.dcaratti@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]

his series wants to simplify, and hopefully improve, random generation
of keys and nonces in crypto.c, While at it, I removed some unneeded
#includes on top of the file. Any feedbacks are welcome!

Note:
 in case you think the code is ok, I will propose to squash it into
 commit a564283a1e38 ("mptcp: Add key generation and token tree")

Changes since v1:
 - add a comment that suggests use of hash to improve performance,
   thanks to Matthieu
 - remove useless #include <tcp.h>, thanks Mat 

Changes since RFC:
 - use get_random_bytes() instead of siphash, thanks to Florian / Mat 


Davide Caratti (2):
  net: mptcp: remove useless #includes in crypto.c
  net: mptcp: randomness improvements for crypto.c

 net/mptcp/crypto.c   | 76 --------------------------------------------
 net/mptcp/protocol.c |  1 -
 net/mptcp/protocol.h | 24 +++++++-------
 net/mptcp/token.c    | 54 ++++---------------------------
 4 files changed, 19 insertions(+), 136 deletions(-)

-- 
2.20.1


             reply	other threads:[~2019-07-23 17:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 17:47 Davide Caratti [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-07-24 12:53 [MPTCP] [PATCH v2 0/2] mptcp: simplify crypto.c Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1563903620.git.dcaratti@redhat.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.