From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Guido=20G=C3=BCnther?= Subject: [PATCH v2 0/4] drm/panel: jh057n00900: Move dsi init sequence to prepare Date: Fri, 26 Jul 2019 15:14:35 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from honk.sigxcpu.org (honk.sigxcpu.org [24.134.29.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2CD886ED44 for ; Fri, 26 Jul 2019 13:14:44 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?q?Guido=20G=C3=BCnther?= , Purism Kernel Team , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org CklmIHRoZSBwYW5lbCBpcyB3cmFwcGVkIGluIGEgcGFuZWxfYnJpZGdlIGl0IGdldHMgcHJlcGFy KCllZCBiZWZvcmUgdGhlCnVwc3RyZWFtIERTSSBicmlkZ2Ugd2hpY2ggY2FuIGNhdXNlIGhhbmdz IChlLmcuIHdpdGggaW14LW53bCBzaW5jZSBjbG9ja3MKYXJlIG5vdCBlbmFibGVkIHlldCkuIFRv IGF2b2lkIHRoaXMgbW92ZSB0aGUgcGFuZWwncyBmaXJzdCBEU0kgYWNjZXNzIHRvCmVuYWJsZSgp IHNvIHRoZSB1cHN0cmVhbSBicmlkZ2UgY2FuIHByZXBhcmUgdGhlIERTSSBob3N0IGNvbnRyb2xs ZXIgaW4KaXQncyBwcmVfZW5hYmxlKCkuCgpUaGUgc2Vjb25kIHBhdGNoIG1ha2VzIHRoZSBkaXNh YmxlKCkgY2FsbCBzeW1tZXRyaWMgdG8gdGhlIGFib3ZlIGFuZCB0aGUgdGhpcmQKb25lIGp1c3Qg ZWFzZXMgZGVidWdnaW5nLgoKQ2hhbmdlcyBmcm9tIHYxOgoqIEFzIHBlciByZXZpZXcgY29tbWVu dHMgYnkgU2FtIFJhdm5ib3JnCiAgKiBJZ25vcmUgZmFpbHVyZXMgdG8gZGlzYWJsZSB0aGUgYmFj a2xpZ2h0IGluIGpoMDU3bl9kaXNhYmxlKCkKICAqIEFkZCAnZHJtL3BhbmVsOiBqaDA1N24wMDkw MDogVXNlIGRybV9wYW5lbF97dW5wcmVwYXJlLGRpc2FibGV9IGNvbnNpc3RlbnRseScKKiBDb2xs ZWN0ZWQgUmV2aWV3ZWQtQnk6IFRoYW5rcyBTYW0hCgpUbzogIkd1aWRvIEfDvG50aGVyIiA8YWd4 QHNpZ3hjcHUub3JnPixQdXJpc20gS2VybmVsIFRlYW0gPGtlcm5lbEBwdXJpLnNtPixUaGllcnJ5 IFJlZGluZyA8dGhpZXJyeS5yZWRpbmdAZ21haWwuY29tPixTYW0gUmF2bmJvcmcgPHNhbUByYXZu Ym9yZy5vcmc+LERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4sRGFuaWVsIFZldHRlciA8 ZGFuaWVsQGZmd2xsLmNoPixkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnLGxpbnV4LWtl cm5lbEB2Z2VyLmtlcm5lbC5vcmcKCgpHdWlkbyBHw7xudGhlciAoNCk6CiAgZHJtL3BhbmVsOiBq aDA1N24wMDkwMDogTW92ZSBwYW5lbCBEU0kgaW5pdCB0byBlbmFibGUoKQogIGRybS9wYW5lbDog amgwNTduMDA5MDA6IE1vdmUgbWlwaV9kc2lfZGNzX3NldF9kaXNwbGF5X29mZiB0byBkaXNhYmxl KCkKICBkcm0vcGFuZWw6IGpoMDU3bjAwOTAwOiBQcmludCBlcnJvciBjb2RlIG9uIGFsbCBEUk1f REVWX0VSUk9SKClzCiAgZHJtL3BhbmVsOiBqaDA1N24wMDkwMDogVXNlIGRybV9wYW5lbF97dW5w cmVwYXJlLGRpc2FibGV9IGNvbnNpc3RlbnRseQoKIC4uLi9kcm0vcGFuZWwvcGFuZWwtcm9ja3Rl Y2gtamgwNTduMDA5MDAuYyAgICB8IDMxICsrKysrKysrKystLS0tLS0tLS0KIDEgZmlsZSBjaGFu Z2VkLCAxNyBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKCi0tIAoyLjIwLjEKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2562BC7618B for ; Fri, 26 Jul 2019 13:15:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04DA522ADA for ; Fri, 26 Jul 2019 13:15:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726857AbfGZNOq (ORCPT ); Fri, 26 Jul 2019 09:14:46 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:36322 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbfGZNOp (ORCPT ); Fri, 26 Jul 2019 09:14:45 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 2CC44FB07; Fri, 26 Jul 2019 15:14:42 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RdK5Fd9fsItN; Fri, 26 Jul 2019 15:14:41 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 0AE6046AA1; Fri, 26 Jul 2019 15:14:40 +0200 (CEST) From: =?UTF-8?q?Guido=20G=C3=BCnther?= To: =?UTF-8?q?Guido=20G=C3=BCnther?= , Purism Kernel Team , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/4] drm/panel: jh057n00900: Move dsi init sequence to prepare Date: Fri, 26 Jul 2019 15:14:35 +0200 Message-Id: X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the panel is wrapped in a panel_bridge it gets prepar()ed before the upstream DSI bridge which can cause hangs (e.g. with imx-nwl since clocks are not enabled yet). To avoid this move the panel's first DSI access to enable() so the upstream bridge can prepare the DSI host controller in it's pre_enable(). The second patch makes the disable() call symmetric to the above and the third one just eases debugging. Changes from v1: * As per review comments by Sam Ravnborg * Ignore failures to disable the backlight in jh057n_disable() * Add 'drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently' * Collected Reviewed-By: Thanks Sam! To: "Guido Günther" ,Purism Kernel Team ,Thierry Reding ,Sam Ravnborg ,David Airlie ,Daniel Vetter ,dri-devel@lists.freedesktop.org,linux-kernel@vger.kernel.org Guido Günther (4): drm/panel: jh057n00900: Move panel DSI init to enable() drm/panel: jh057n00900: Move mipi_dsi_dcs_set_display_off to disable() drm/panel: jh057n00900: Print error code on all DRM_DEV_ERROR()s drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently .../drm/panel/panel-rocktech-jh057n00900.c | 31 ++++++++++--------- 1 file changed, 17 insertions(+), 14 deletions(-) -- 2.20.1