From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Linux Edac Mailing List <linux-edac@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
Robert Richter <rrichter@marvell.com>,
James Morse <james.morse@arm.com>
Subject: [PATCH 0/7] Address most issues when building with W=1
Date: Fri, 13 Sep 2019 11:50:25 -0300 [thread overview]
Message-ID: <cover.1568385816.git.mchehab+samsung@kernel.org> (raw)
There is a recent discussion at KS ML with regards to use W=1 as default.
No idea if this will happen or not, but it doesn't hurt cleaning up W=1
warnings from the EDAC subsystem, specially since it helps to cleanup
a few things.
This patch series addresses most of such warnings. After this series,
there will be just two W=1 warnings:
1) i5100 EDAC driver:
drivers/edac/i5100_edac.c: In function ‘i5100_read_log’:
drivers/edac/i5100_edac.c:487:11: warning: variable ‘ecc_loc’ set but not used [-Wunused-but-set-variable]
487 | unsigned ecc_loc = 0;
| ^~~~~~~
The ecc_loc contents is filled from MC data, but it is not used anywere.
The i5100 MC is very old: the affected code was added in 2008. It should
probably be safe to just drop the corresponding data, but, as it may
contain some relevant info, I was a little reticent of doing that.
2) Xgene EDAC driver:
drivers/edac/xgene_edac.c: In function ‘xgene_edac_rb_report’:
drivers/edac/xgene_edac.c:1486:7: warning: variable ‘address’ set but not used [-Wunused-but-set-variable]
1486 | u32 address;
| ^~~~~~~
I suspect that the content of the address field should actually be used on
at least some of the logs.
I may eventually submit patches later to address the above cases, but let's
solve first the other cases, as they all sound trivial enough.
Mauro Carvalho Chehab (7):
EDAC: i5100_edac: get rid of an unused var
EDAC: i7300_edac: rename a kernel-doc var description
EDAC: i7300_edac: fix a kernel-doc syntax
EDAC: i5400_edac: print type at debug message
EDAC: i5400_edac: get rid of some unused vars
EDAC: sb_edac: get rid of unused vars
EDAC: skx_common: get rid of unused type var
drivers/edac/i5100_edac.c | 2 --
drivers/edac/i5400_edac.c | 15 +++------------
drivers/edac/i7300_edac.c | 4 ++--
drivers/edac/sb_edac.c | 21 ++++++++-------------
drivers/edac/skx_common.c | 5 +----
5 files changed, 14 insertions(+), 33 deletions(-)
--
2.21.0
next reply other threads:[~2019-09-13 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 14:50 Mauro Carvalho Chehab [this message]
2019-09-13 14:50 ` [PATCH 1/7] EDAC: i5100_edac: get rid of an unused var Mauro Carvalho Chehab
2019-09-13 14:50 ` [PATCH 2/7] EDAC: i7300_edac: rename a kernel-doc var description Mauro Carvalho Chehab
2019-09-13 14:50 ` [PATCH 3/7] EDAC: i7300_edac: fix a kernel-doc syntax Mauro Carvalho Chehab
2019-09-13 14:50 ` [PATCH 4/7] EDAC: i5400_edac: print type at debug message Mauro Carvalho Chehab
2019-09-13 14:50 ` [PATCH 5/7] EDAC: i5400_edac: get rid of some unused vars Mauro Carvalho Chehab
2019-09-13 14:50 ` [PATCH 6/7] EDAC: sb_edac: get rid of " Mauro Carvalho Chehab
2019-09-13 14:50 ` [PATCH 7/7] EDAC: skx_common: get rid of unused type var Mauro Carvalho Chehab
2019-09-13 17:53 ` [PATCH 0/7] Address most issues when building with W=1 Borislav Petkov
2019-09-13 17:55 ` Luck, Tony
2019-09-13 18:05 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1568385816.git.mchehab+samsung@kernel.org \
--to=mchehab+samsung@kernel.org \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.