All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 00/11] drm/i915: modeset probe/remove cleanup
Date: Mon,  7 Oct 2019 18:09:25 +0300	[thread overview]
Message-ID: <cover.1570460714.git.jani.nikula@intel.com> (raw)

Another attempt at trying to cleanup the probe/remove wrt
display. TL;DR: It's a mess.

I'm trying to chop up the intel_modeset_*() functions in intel_display.c
to smaller pieces, and eventually remove the extra
i915_driver_modeset_*() layer from i915_drv.c.

The intermediate steps aren't the prettiest. The error paths in
particular are hideous. (Not that they are great now.)

But I'm trying to probe (eh) if this would be a workable direction.

BR,
Jani.


Jani Nikula (11):
  drm/i915: register vga switcheroo later, unregister earlier
  drm/i915: switch i915_driver_probe() to use i915 local variable
  drm/i915: keep power domains init/remove calls at the same level
  drm/i915: split intel_modeset_driver_remove() to pre/post irq
    uninstall
  drm/i915: split i915_driver_modeset_remove() to pre/post irq uninstall
  drm/i915: split i915_driver_modeset_probe() to pre/post irq install
  drm/i915: split intel_modeset_init() to pre/post irq install
  drm/i915: split intel_modeset_init() pre/post gem init
  drm/i915: move more display related probe/remove stuff to display
  drm/i915: move modeset probe failures down to intel_display.c
  drm/i915: remove the now redundant i915_driver_modeset_* call layer

 drivers/gpu/drm/i915/display/intel_display.c |  82 +++++++--
 drivers/gpu/drm/i915/display/intel_display.h |   3 +
 drivers/gpu/drm/i915/i915_drv.c              | 183 +++++++------------
 3 files changed, 141 insertions(+), 127 deletions(-)

-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2019-10-07 15:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 15:09 Jani Nikula [this message]
2019-10-07 15:09 ` [PATCH 01/11] drm/i915: register vga switcheroo later, unregister earlier Jani Nikula
2019-10-07 15:09 ` [PATCH 02/11] drm/i915: switch i915_driver_probe() to use i915 local variable Jani Nikula
2019-10-07 20:40   ` Chris Wilson
2019-10-07 15:09 ` [PATCH 03/11] drm/i915: keep power domains init/remove calls at the same level Jani Nikula
2019-10-08 12:14   ` Jani Nikula
2019-10-07 15:09 ` [PATCH 04/11] drm/i915: split intel_modeset_driver_remove() to pre/post irq uninstall Jani Nikula
2019-10-07 15:09 ` [PATCH 05/11] drm/i915: split i915_driver_modeset_remove() " Jani Nikula
2019-10-07 15:09 ` [PATCH 06/11] drm/i915: split i915_driver_modeset_probe() to pre/post irq install Jani Nikula
2019-10-07 15:09 ` [PATCH 07/11] drm/i915: split intel_modeset_init() " Jani Nikula
2019-10-07 15:09 ` [PATCH 08/11] drm/i915: split intel_modeset_init() pre/post gem init Jani Nikula
2019-10-07 15:09 ` [PATCH 09/11] drm/i915: move more display related probe/remove stuff to display Jani Nikula
2019-10-07 15:09 ` [PATCH 10/11] drm/i915: move modeset probe failures down to intel_display.c Jani Nikula
2019-10-07 15:09 ` [PATCH 11/11] drm/i915: remove the now redundant i915_driver_modeset_* call layer Jani Nikula
2019-10-07 15:26   ` Chris Wilson
2019-10-07 15:39 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: modeset probe/remove cleanup Patchwork
2019-10-07 16:30 ` ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1570460714.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.