From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5227289498014587827==" MIME-Version: 1.0 From: Davide Caratti To: mptcp at lists.01.org Subject: [MPTCP] [PATCH v2 0/2] mptcp: disallow setting the MPTCP ULP from userspace Date: Mon, 14 Oct 2019 16:46:08 +0200 Message-ID: X-Status: X-Keywords: X-UID: 2107 --===============5227289498014587827== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable with this series we make setscokopt(..., IPPROTO_TCP, TCP_ULP, "mptcp", sizeof("mptcp")); return -1 and set errno to -EOPNOPSUPPORT. this allows attaching MPTCP ULP only to a TCP socket that has been created through sock_create_kern(). - Patch 1/2 lets subflow_init() fail with -EOPNOTSUPPORT in case users try to setsockopt(..., TCP_ULP) on a TCP socket that has been created by a userspace program. I suggest squashing this patch in "mptcp: Associate MPTCP context with TCP socket". - Patch 2/2 includes kselftest code. I suggest squashing it with "mptcp: add basic kselftest for mptcp". Changes since v1: - don't redirect the selftest output to /dev/null = - test output depends on the value of 'errno', to avoid false negative in case kernel is built without CONFIG_MPTCP Davide Caratti (2): mptcp: subflow: disallow setsockopt(... TCP_ULP, "mptcp") selftests: test setsockopt(..., TCP_ULP, "mptcp", ...) net/mptcp/subflow.c | 7 +++ .../selftests/net/mptcp/mptcp_connect.c | 52 +++++++++++++++++-- .../selftests/net/mptcp/mptcp_connect.sh | 19 +++++++ 3 files changed, 75 insertions(+), 3 deletions(-) -- = 2.21.0 --===============5227289498014587827==--