From: Lorenzo Bianconi <lorenzo@kernel.org>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org, nbd@nbd.name,
hkallweit1@gmail.com, sgruszka@redhat.com,
lorenzo.bianconi@redhat.com, oleksandr@natalenko.name,
netdev@vger.kernel.org
Subject: [PATCH v3 wireless-drivers 0/2] fix mt76x2e hangs on U7612E mini-pcie
Date: Sun, 27 Oct 2019 20:53:07 +0100 [thread overview]
Message-ID: <cover.1572204430.git.lorenzo@kernel.org> (raw)
Various mt76x2e issues have been reported on U7612E mini-pcie card [1].
On U7612E-H1 PCIE_ASPM causes continuous mcu hangs and instability and
so patch 1/2 disable it by default.
Moreover mt76 does not properly unmap dma buffers for non-linear skbs.
This issue may result in hw hangs if the system relies on IOMMU.
Patch 2/2 fix the problem properly unmapping data fragments on
non-linear skbs.
Changes since v2:
- fix compilation error if PCI support is not compiled
Changes since v1:
- simplify buf0 unmap condition
- use IS_ENABLED(CONFIG_PCIEASPM) instead of ifdef CONFIG_PCIEASPM
- check pci_disable_link_state return value
[1]: https://lore.kernel.org/netdev/deaafa7a3e9ea2111ebb5106430849c6@natalenko.name/
Lorenzo Bianconi (2):
mt76: mt76x2e: disable pcie_aspm by default
mt76: dma: fix buffer unmap with non-linear skbs
drivers/net/wireless/mediatek/mt76/Makefile | 2 +
drivers/net/wireless/mediatek/mt76/dma.c | 6 ++-
drivers/net/wireless/mediatek/mt76/mt76.h | 6 ++-
.../net/wireless/mediatek/mt76/mt76x2/pci.c | 2 +
drivers/net/wireless/mediatek/mt76/pci.c | 46 +++++++++++++++++++
5 files changed, 58 insertions(+), 4 deletions(-)
create mode 100644 drivers/net/wireless/mediatek/mt76/pci.c
--
2.21.0
next reply other threads:[~2019-10-27 19:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 19:53 Lorenzo Bianconi [this message]
2019-10-27 19:53 ` [PATCH v3 wireless-drivers 1/2] mt76: mt76x2e: disable pcie_aspm by default Lorenzo Bianconi
2019-10-27 21:40 ` Oleksandr Natalenko
2019-10-30 15:00 ` Kalle Valo
2019-10-27 19:53 ` [PATCH v3 wireless-drivers 2/2] mt76: dma: fix buffer unmap with non-linear skbs Lorenzo Bianconi
2019-10-28 7:17 ` [PATCH v3 wireless-drivers 0/2] fix mt76x2e hangs on U7612E mini-pcie Oleksandr Natalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1572204430.git.lorenzo@kernel.org \
--to=lorenzo@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.