From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8355480639151983709==" MIME-Version: 1.0 From: Paolo Abeni To: mptcp at lists.01.org Subject: [MPTCP] [PATCH v1 0/4] mptcp: fallback socket cleanup Date: Tue, 10 Dec 2019 00:52:06 +0100 Message-ID: X-Status: X-Keywords: X-UID: 2848 --===============8355480639151983709== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This is a rebase on top of last rebased by Florian. The old patch 2/5 has been dropped - obsoleted by Florian's patches - and t= he following patches has been reworked a bit, due to mptcp_subflow_tcp_socket(= ) -> mptcp_subflow_tcp_sock() change. = Last patch now also deal with mptcp_copy_inaddrs() in order to remove the l= ock from mptcp_finish_connect() we must move that to connect() and calling it a= lso from bind(), listen() allows simplifying mptcp_getname(), too. >From the original cover letter: --- After all the above, performance for connection fallen back to plain TCP sh= ould be almost the same of TCP connection on unpacked kernel. Addittionally 'nc' and 'netperf' now run successfully when forced to MPTCP. The latter still report a non fatal error at connection closing time as it performs: getsockopt(4, SOL_TCP, TCP_MAXSEG, //...); getsockopt(4, SOL_TCP, TCP_INFO, //...); which is still unsupported after that the mp capable handshake is started. For the records on the debug build I'm using netperf scores better result with MPTCP that with plain TCP ;) [agreed, completely irrelevant, still nic= e] The series applies at selftests and is unsquashed - will require quite a bit of work there and more work to rebase/adjust the patches after kselftest. I'll start that after the pending patches are in. _Any_ feedback _very_ welcome! Paolo Abeni (4): mptcp: clear 'is_tcp' socket flag when the MP_CAPABLE handshake fails imptcp: cleanup fallback handling mptcp: add subflow to conn_list early mptcp: avoid acquiring the msk lock in mptcp_finisch_connect() net/mptcp/options.c | 3 + net/mptcp/protocol.c | 320 +++++++++++++++++++++---------------------- net/mptcp/subflow.c | 2 + 3 files changed, 163 insertions(+), 162 deletions(-) -- = 2.21.0 --===============8355480639151983709==--