From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f194.google.com ([209.85.214.194]:38764 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728996AbfLQQPv (ORCPT ); Tue, 17 Dec 2019 11:15:51 -0500 From: Thomas Hebb Subject: [PATCH v2 0/3] kconfig: rework symbol help text Date: Tue, 17 Dec 2019 08:15:42 -0800 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Thomas Hebb , Palmer Dabbelt , Paul Walmsley , linux-riscv@lists.infradead.org This series fixes several issues with help text generated by Kconfig, mainly affecting symbols that are defined in multiple places. Although results of these patches are somewhat visible for the symbols in Linux, what prompted me to write the series was working on U-Boot, which also uses Kconfig and makes very heavy use of multiple definitions (e.g. for overriding defaults). I have provided Linux examples where I could find them, but the example for the biggest patch (the first one) is taken from U-Boot because it was more illustrative than anything I could find in Linux. Changes in v2: - Added explicit U-Boot version in commit message + other rewordings - Made the new "Depends on:" line print actual dependencies instead of visibility to avoid an intra-series regression, and noted that in the commit message. - Get rid of redundant "with prompt" and "without prompt" notes in definition text, but continue to ensure that definitions with prompts are printed before ones without. - Fixed checkpatch issues - Omit already-merged patch "kconfig: don't crash on NULL expressions in expr_eq()" Thomas Hebb (3): kconfig: list all definitions of a symbol in help text kconfig: distinguish between dependencies and visibility in help text kconfig: fix nesting of symbol help text scripts/kconfig/expr.c | 3 +- scripts/kconfig/expr.h | 1 + scripts/kconfig/menu.c | 82 +++++++++++++++++++++++++----------------- 3 files changed, 52 insertions(+), 34 deletions(-) -- 2.24.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF35C2D0CD for ; Tue, 17 Dec 2019 16:15:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1063021835 for ; Tue, 17 Dec 2019 16:15:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a8xd1O6v"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ElECYMtB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1063021835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=CZrp8UQQ+bj1ts8a/GF/7XEl3PQrDG+nT1WZvWpq3rU=; b=a8xd1O6vRqy9v2 bjFlDf50jqfDphI9tUNorbhvDTrLTiNP/oQbttIUjG2XA1t64fKgmmwcjZf806+sn0Jh50SWA7vgI XJbqqMTIYf9a0oY0NsrpblMCevgrXUnuuTrD6ga6/DEpWnhZnuwOXPLnszQtvuObhrBOEtYQjZv2b IyOiIWchFi/nCC/uKetJCb0kPJFMudffazP7E9FUz6h9ncP2hcYZCGQOrKv8lU4m0uftZpgSHvTr6 L0OsV08vYEszaeXhDM1HfNIzS4BOaiWUA/ZIiFHYqNalTiY13qPA4Nq19Kq5RjZZtyQvYC978d0HO zDZzi3y3j8Dju0TjTO4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihFVr-0008MB-1L; Tue, 17 Dec 2019 16:15:55 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihFVo-0008L6-Uo for linux-riscv@lists.infradead.org; Tue, 17 Dec 2019 16:15:54 +0000 Received: by mail-pl1-x643.google.com with SMTP id b22so3378926pls.12 for ; Tue, 17 Dec 2019 08:15:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CZrp8UQQ+bj1ts8a/GF/7XEl3PQrDG+nT1WZvWpq3rU=; b=ElECYMtBZrjFvxUHRBwyhYr5cB2bkw1bFyOwZFb0Co8YbMQh1sOaOIWqnnAufDE3iN zuUHWh27aaD86ekJA8WIqAVyJ+MhhEXpIYhymS8vUsjkuABzSXFR+wS47PnqxgpZ4i/1 Lv6MpQzcUayUOX/m6RgVbqKZB26xKyv2OBmimMy3dzXWkw0o30zzQ97opWZ3h5ULU0ZE iPVwg/WHbTgScdQb8xnitqtLzV3RzMTQ2J2IMHPrBt7WNa9HD3ZYuOh0N79qR16jRSwZ Zxdh5E6l61Fk+dzWCsgdwaBHtAlFqVrx7Wb/VJBXvcDNgEBFjcbyjDWShvNPCqdv7ZK8 enuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CZrp8UQQ+bj1ts8a/GF/7XEl3PQrDG+nT1WZvWpq3rU=; b=OHFpRbTsHlWM+YkmAykeAtHI9qBiSx13gwMAQniiM01oVTnCOpryM5xULvoBdxy8m7 pqBcFPWKWx0EBd5hDMBzorc+zz83cc+pX6UWleJ6acSNULMSDRY/em4rrK05p4Wt2HVM vWaQJcNPgrrls/ioK4Q+ixlqilHyX6TdHQ0x/s+pfnuwU2f4F02cyu6KXcSFrOZ4/GJt 22MRuoZpx9xC5aGoDKYzofI53ukbInOOpUxJX51G7OsRCRzto/peQecHNqVN/6AYEQ68 X/VHwOEV196daz4v8gYa4sC8giXgIQUNSZ4+I+dHiQCNhjDBHkg0uVVDZq3WHfzDumfr vr5g== X-Gm-Message-State: APjAAAUuCmu9EHYWZMYH0WYJml7J3rlkfES9E1HwGadUurzbuImsUjgy qpbmDHHIzKq7g0nVtiZDqEEXItMi7co= X-Google-Smtp-Source: APXvYqyIekrKyUdm7+MOpp/lryRy6OV5UID6PpLqjzjTibQ1QruJuc89eTrWbhjtW8+MHpFU6P8mzQ== X-Received: by 2002:a17:902:6b09:: with SMTP id o9mr13938481plk.209.1576599349747; Tue, 17 Dec 2019 08:15:49 -0800 (PST) Received: from glados.lan ([2601:647:4c01:6541:fa16:54ff:fed1:1bd6]) by smtp.gmail.com with ESMTPSA id k15sm27704122pfg.37.2019.12.17.08.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 08:15:48 -0800 (PST) From: Thomas Hebb To: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: [PATCH v2 0/3] kconfig: rework symbol help text Date: Tue, 17 Dec 2019 08:15:42 -0800 Message-Id: X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191217_081552_995078_AA2C9F90 X-CRM114-Status: UNSURE ( 9.46 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Masahiro Yamada , Thomas Hebb , Palmer Dabbelt , linux-riscv@lists.infradead.org, Paul Walmsley Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org This series fixes several issues with help text generated by Kconfig, mainly affecting symbols that are defined in multiple places. Although results of these patches are somewhat visible for the symbols in Linux, what prompted me to write the series was working on U-Boot, which also uses Kconfig and makes very heavy use of multiple definitions (e.g. for overriding defaults). I have provided Linux examples where I could find them, but the example for the biggest patch (the first one) is taken from U-Boot because it was more illustrative than anything I could find in Linux. Changes in v2: - Added explicit U-Boot version in commit message + other rewordings - Made the new "Depends on:" line print actual dependencies instead of visibility to avoid an intra-series regression, and noted that in the commit message. - Get rid of redundant "with prompt" and "without prompt" notes in definition text, but continue to ensure that definitions with prompts are printed before ones without. - Fixed checkpatch issues - Omit already-merged patch "kconfig: don't crash on NULL expressions in expr_eq()" Thomas Hebb (3): kconfig: list all definitions of a symbol in help text kconfig: distinguish between dependencies and visibility in help text kconfig: fix nesting of symbol help text scripts/kconfig/expr.c | 3 +- scripts/kconfig/expr.h | 1 + scripts/kconfig/menu.c | 82 +++++++++++++++++++++++++----------------- 3 files changed, 52 insertions(+), 34 deletions(-) -- 2.24.1