From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Subject: [POC RFC 0/3] splice(2) support for io_uring
Date: Wed, 22 Jan 2020 03:05:16 +0300 [thread overview]
Message-ID: <cover.1579649589.git.asml.silence@gmail.com> (raw)
It works well for basic cases, but there is still work to be done. E.g.
it misses @hash_reg_file checks for the second (output) file. Anyway,
there are some questions I want to discuss:
- why sqe->len is __u32? Splice uses size_t, and I think it's better
to have something wider (e.g. u64) for fututre use. That's the story
behind added sqe->splice_len.
- it requires 2 fds, and it's painful. Currently file managing is done
by common path (e.g. io_req_set_file(), __io_req_aux_free()). I'm
thinking to make each opcode function handle file grabbing/putting
themself with some helpers, as it's done in the patch for splice's
out-file.
1. Opcode handler knows, whether it have/needs a file, and thus
doesn't need extra checks done in common path.
2. It will be more consistent with splice.
Objections? Ideas?
- do we need offset pointers with fallback to file->f_pos? Or is it
enough to have offset value. Jens, I remember you added the first
option somewhere, could you tell the reasoning?
Pavel Begunkov (3):
splice: make do_splice public
io_uring: add interface for getting files
io_uring: add splice(2) support
fs/io_uring.c | 152 ++++++++++++++++++++++++++++------
fs/splice.c | 6 +-
include/linux/splice.h | 3 +
include/uapi/linux/io_uring.h | 16 +++-
4 files changed, 147 insertions(+), 30 deletions(-)
--
2.24.0
next reply other threads:[~2020-01-22 0:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 0:05 Pavel Begunkov [this message]
2020-01-22 0:05 ` [PATCH 1/3] splice: make do_splice public Pavel Begunkov
2020-01-22 0:05 ` [PATCH 2/3] io_uring: add interface for getting files Pavel Begunkov
2020-01-22 1:54 ` Jens Axboe
2020-01-22 2:24 ` Pavel Begunkov
2020-01-22 0:05 ` [PATCH 3/3] io_uring: add splice(2) support Pavel Begunkov
2020-01-22 2:03 ` Jens Axboe
2020-01-22 2:40 ` Pavel Begunkov
2020-01-22 2:47 ` Jens Axboe
2020-01-22 3:16 ` Pavel Begunkov
2020-01-22 3:22 ` Jens Axboe
2020-01-24 12:31 ` kbuild test robot
2020-01-24 12:31 ` kbuild test robot
2020-01-25 18:28 ` kbuild test robot
2020-01-25 18:28 ` kbuild test robot
2020-01-22 1:55 ` [POC RFC 0/3] splice(2) support for io_uring Jens Axboe
2020-01-22 3:11 ` Pavel Begunkov
2020-01-22 3:30 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2020-04-06 19:09 Askar Safin
2020-04-06 20:01 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1579649589.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.