All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni at redhat.com>
To: mptcp at lists.01.org
Subject: [MPTCP] [RFC PATCH 0/6] dd locking to PM APis, implement PM netlink
Date: Tue, 11 Feb 2020 19:12:07 +0100	[thread overview]
Message-ID: <cover.1581444137.git.pabeni@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]

Sending as an early RFC to gather feedback, as this is proving to be more
intrusive that what I initially hoped for.

This implement the locking required by the PM to allow concurent subflow
accessing the msk PM data in a safe way. Such data is protected via a msk-level
spinlock. It relies on the Double checked locking to avoid contention in the
most common scenarion (no or very little PM "actions").

Overall the above adds quite a bit of code churn, is that a too premature
optimization? On the flip side, the whole PM processing should be quite
light on the CPU in most cases.

Additionally changes more than a bit the PM hooks/APIs, to be hopefully simpler
and avoiding duplicate code (no v4/v6 variant, work queue management done by the
core PM infra).

It also introduce the PM netlink - should replace the current basic ones.
Completely untested but please have a look at the specified netlink uAPI.

TODO:
 - implement U/S helper
 - self-tests
 - do we need NL dump operation to inspect the PM netlink status?

 include/uapi/linux/mptcp.h |   42 +++
 net/mptcp/Makefile         |    3 
 net/mptcp/options.c        |   59 ++---
 net/mptcp/pm.c             |  340 +++++++++++++----------------
 net/mptcp/pm_netlink.c     |  524 +++++++++++++++++++++++++++++++++++++++++++++
 net/mptcp/protocol.c       |    2 
 net/mptcp/protocol.h       |  110 +++++----
 net/mptcp/subflow.c        |   63 +++--
 8 files changed, 872 insertions(+), 271 deletions(-)

                 reply	other threads:[~2020-02-11 18:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1581444137.git.pabeni@redhat.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.