All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: grub-devel@gnu.org
Cc: Patrick Steinhardt <ps@pks.im>, Olaf Hering <olaf@aepfle.de>,
	Paul Menzel <pmenzel@molgen.mpg.de>,
	Daniel Kiper <dkiper@net-space.pl>
Subject: [PATCH 0/2] build: Fixes for memory-debugging builds
Date: Sat,  7 Mar 2020 17:29:07 +0100	[thread overview]
Message-ID: <cover.1583584285.git.ps@pks.im> (raw)

Hi,

this series fixes two issues I've found after investigating the build
failures for LUKS2:

    - Including <config-util.h> in base64.h is the wrong thing to do as
      it's also used in the luks2 module, which shouldn't include the
      util header at all.

    - Ironically, explicitly disabling memory debugging enables memory
      debugging while it would've been disabled if just passing no
      option at all.

These patches fix both issues so that GRUB now builds correctly with and
without memory debugging on my system.

Patrick


Patrick Steinhardt (2):
  build: Fix option to explicitly disable memory debugging
  gnulib: Fix build of base64 when compiling with memory debugging

 configure.ac                                  |  8 +++++---
 grub-core/lib/gnulib-patches/fix-base64.patch | 14 ++++++--------
 2 files changed, 11 insertions(+), 11 deletions(-)

-- 
2.25.1



             reply	other threads:[~2020-03-07 16:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-07 16:29 Patrick Steinhardt [this message]
2020-03-07 16:29 ` [PATCH 1/2] build: Fix option to explicitly disable memory debugging Patrick Steinhardt
2020-03-09 11:09   ` Daniel Kiper
2020-03-09 11:18   ` Paul Menzel
2020-03-09 12:22     ` Patrick Steinhardt
2020-03-09 12:31       ` Daniel Kiper
2020-03-07 16:29 ` [PATCH 2/2] gnulib: Fix build of base64 when compiling with " Patrick Steinhardt
2020-03-09 11:19   ` Daniel Kiper
2020-03-09 12:01     ` Patrick Steinhardt
2020-03-09 12:14       ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1583584285.git.ps@pks.im \
    --to=ps@pks.im \
    --cc=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=olaf@aepfle.de \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.