All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gaetan Rivet <grive@u256.net>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v1 0/2] bonding: fix port id check and PCI addr cmp
Date: Fri, 17 Apr 2020 18:42:05 +0200	[thread overview]
Message-ID: <cover.1587137703.git.grive@u256.net> (raw)

Found these two bugs while reading the bonding code.

The first bug is mostly usability: if a user gives an incorrect port id
as a slave, it will error-out later. The error will simply be less
clear.

I'm partially responsible for the second one. I don't see why we did not
wrote it properly at the time: the comment about lacking the proper
rte_bus_pci impl was already not correct anymore when the check on the kdrv
was removed. The necessary functions were already available I think.

Gaetan Rivet (2):
  bonding: fix port id validity check on parsing
  bonding: fix PCI address comparison on non-pci ports

 drivers/net/bonding/rte_eth_bond_args.c | 63 +++++++++++--------------
 1 file changed, 27 insertions(+), 36 deletions(-)

-- 
2.26.0


             reply	other threads:[~2020-04-17 16:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17 16:42 Gaetan Rivet [this message]
2020-04-17 16:42 ` [dpdk-dev] [PATCH v1 1/2] bonding: fix port id validity check on parsing Gaetan Rivet
2020-11-26  2:45   ` [dpdk-dev] [PATCH v1, " Min Hu (Connor)
2020-12-07 13:34     ` Ferruh Yigit
2020-04-17 16:42 ` [dpdk-dev] [PATCH v1 2/2] bonding: fix PCI address comparison on non-pci ports Gaetan Rivet
2020-11-26  2:24   ` [dpdk-dev] [v1, " Min Hu (Connor)
2020-12-07 14:07     ` Gaëtan Rivet
2020-12-16 12:14       ` Min Hu (Connor)
2020-12-17 10:53         ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1587137703.git.grive@u256.net \
    --to=grive@u256.net \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.