From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>, gitster@pobox.com
Subject: [PATCH v2 0/4] No-lazy-fetch has_object() and some fixes
Date: Wed, 5 Aug 2020 16:06:48 -0700 [thread overview]
Message-ID: <cover.1596668156.git.jonathantanmy@google.com> (raw)
In-Reply-To: <20200728010403.95142-1-jonathantanmy@google.com>
Since v1, I've took a look at 3 other cases that use has_object_file():
2 don't need lazy-fetching (patches 3 and 4 in this set) and 1 does -
"cat-file -e" - although I think this is a special case. So I still
think that not lazy-fetching when checking object existence is more
likely, and should be privileged with the shorter function name
(has_object() instead of has_object_locally()).
Changes from v1:
- Patch split into 2 (patch 1 and patch 2)
- 2 additional patches that fix bugs by making use of the new function
Jonathan Tan (4):
sha1-file: introduce no-lazy-fetch has_object()
apply: do not lazy fetch when applying binary
pack-objects: no fetch when allow-{any,promisor}
fsck: do not lazy fetch known non-promisor object
Documentation/git-pack-objects.txt | 11 +++++++----
apply.c | 2 +-
builtin/fsck.c | 2 +-
builtin/pack-objects.c | 4 ++--
object-store.h | 25 +++++++++++++++++++++++--
sha1-file.c | 12 ++++++++++++
t/t4150-am.sh | 16 ++++++++++++++++
7 files changed, 62 insertions(+), 10 deletions(-)
--
2.28.0.236.gb10cc79966-goog
next prev parent reply other threads:[~2020-08-05 23:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 1:04 [PATCH] apply: do not fetch when checking object existence Jonathan Tan
2020-07-28 1:19 ` Junio C Hamano
2020-07-28 18:23 ` Jonathan Tan
2020-08-05 23:06 ` Jonathan Tan [this message]
2020-08-05 23:06 ` [PATCH v2 1/4] sha1-file: introduce no-lazy-fetch has_object() Jonathan Tan
2020-08-05 23:06 ` [PATCH v2 2/4] apply: do not lazy fetch when applying binary Jonathan Tan
2020-08-05 23:06 ` [PATCH v2 3/4] pack-objects: no fetch when allow-{any,promisor} Jonathan Tan
2020-08-05 23:06 ` [PATCH v2 4/4] fsck: do not lazy fetch known non-promisor object Jonathan Tan
2020-08-06 20:00 ` [PATCH v2 0/4] No-lazy-fetch has_object() and some fixes Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1596668156.git.jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.