From: Benjamin Coddington <bcodding@redhat.com>
To: trond.myklebust@hammerspace.com, anna.schumaker@netapp.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 0/2 v2] a stateid race and a cleanup
Date: Tue, 22 Sep 2020 15:15:47 -0400 [thread overview]
Message-ID: <cover.1600801124.git.bcodding@redhat.com> (raw)
Cover letter this time explaining the v2: Anna helped me find that the
first version's stable fix was wrong, but was fixed by the refactor patch
that followed.
After putting in the logic to fix the stable version, it was messy enough
that it made more sense to squash the two patches together. So, this time
the first patch does rewrite nfs_need_update_open_stateid a bit more in
order to handle both cases:
- where two OPENs race to NFS_OPEN_STATE and the second wins
- where an OPEN and CLOSE+1 race to update nfs4_state and CLOSE+1 wins
The end result is that these two patches are code-equivalent to the first
three. (It is still getting one final run through my testing, but I haven't
delayed posting for that).
Benjamin Coddington (2):
NFSv4: Fix a livelock when CLOSE pre-emptively bumps state sequence
NFSv4: cleanup unused zero_stateid copy
fs/nfs/nfs4proc.c | 27 +++++++++++++++++----------
fs/nfs/nfs4state.c | 8 ++------
2 files changed, 19 insertions(+), 16 deletions(-)
--
2.20.1
next reply other threads:[~2020-09-22 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 19:15 Benjamin Coddington [this message]
2020-09-22 19:15 ` [PATCH 1/2 v2] NFSv4: Fix a livelock when CLOSE pre-emptively bumps state sequence Benjamin Coddington
2020-09-22 19:48 ` Trond Myklebust
2020-09-22 21:08 ` Benjamin Coddington
2020-09-22 21:15 ` Trond Myklebust
2020-09-22 21:46 ` Trond Myklebust
2020-09-22 22:38 ` Benjamin Coddington
2020-09-22 19:15 ` [PATCH 2/2 v2] NFSv4: cleanup unused zero_stateid copy Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1600801124.git.bcodding@redhat.com \
--to=bcodding@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.