From: Tom Zanussi <zanussi@kernel.org>
To: rostedt@goodmis.org, axelrasmussen@google.com
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/3] tracing: Add dynamic strings for synthetic events
Date: Thu, 1 Oct 2020 16:46:43 -0500 [thread overview]
Message-ID: <cover.1601588066.git.zanussi@kernel.org> (raw)
Hi,
This is v3 of the dynamic string support for synthetic events.
No code changes since v2, just added Fixes: tag for 'tracing: Fix
parse_synth_field() error handling' as suggested by Masami along with
his Reviewed-by, and Axel's Tested-bys.
Thanks,
Tom
Previous versions text:
Hi,
This is v2 of the dynamic string support for synthetic events.
v1 was missing some very important code in the in-kernel API functions
that should have reserved room for dynamic strings. This adds it
along also some additional test code in the synth_event_gen_test
module that tests the dynamic strings for those APIs.
I also added Axel's changelog text to the 'tracing: Fix
parse_synth_field() error handling' patch and used ssize_t as he also
suggested. Thanks, Axel! I also noticed that the original patch
didn't use <= as it should have, so changed that as well.
Neither my command-line tests or the synth_event_gen_test module are
showing any problems at this point for me...
Tom
Original v1 text:
This patchset adds support for dynamic strings for synthetic events,
as requested by Axel Rasmussen.
Actually, the first two patches should be applied in any case - the
first just changes the current max string length and the second fixes
a bug I found while testing.
It works fine for my simple test cases, but I still need to do a lot
more testing, especially of the in-kernel API parts, which don't
affect Axel's use case.
Anyway, Axel, please try it out and send me your Tested-by: if it
works for you, and your broken testcase(s) if it doesn't. ;-)
Thanks,
Tom
The following changes since commit fdb46faeab2f3fa2b43a55059b33b8f98b2e1442:
x86: Use tracepoint_enabled() for msr tracepoints instead of open coding it (2020-09-28 10:36:02 -0400)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/synth-dynstring-v3
Tom Zanussi (3):
tracing: Change STR_VAR_MAX_LEN
tracing: Fix parse_synth_field() error handling
tracing: Add support for dynamic strings to synthetic events
Documentation/trace/events.rst | 15 +-
Documentation/trace/histogram.rst | 18 +++
kernel/trace/synth_event_gen_test.c | 18 ++-
kernel/trace/trace_events_hist.c | 9 ++
kernel/trace/trace_events_synth.c | 243 ++++++++++++++++++++++++----
kernel/trace/trace_synth.h | 6 +-
6 files changed, 269 insertions(+), 40 deletions(-)
--
2.17.1
next reply other threads:[~2020-10-01 21:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 21:46 Tom Zanussi [this message]
2020-10-01 21:46 ` [PATCH v3 1/3] tracing: Change STR_VAR_MAX_LEN Tom Zanussi
2020-10-02 19:44 ` Steven Rostedt
2020-10-02 22:04 ` Tom Zanussi
2020-10-01 21:46 ` [PATCH v3 2/3] tracing: Fix parse_synth_field() error handling Tom Zanussi
2020-10-01 21:46 ` [PATCH v3 3/3] tracing: Add support for dynamic strings to synthetic events Tom Zanussi
2020-10-03 0:55 ` [PATCH v3 0/3] tracing: Add dynamic strings for " Steven Rostedt
2020-10-03 1:00 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1601588066.git.zanussi@kernel.org \
--to=zanussi@kernel.org \
--cc=axelrasmussen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.